Chromium Code Reviews

Issue 2055753002: VoERTP_RTCP: Remove GetREDStatus and SetREDStatus (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-red
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VoERTP_RTCP: Remove GetREDStatus and SetREDStatus They always fail, because RED isn't supported. BUG=webrtc:5922 Committed: https://crrev.com/0ccff57024c0b5f88fa10f177c6370b4e9447ce7 Cr-Commit-Position: refs/heads/master@{#13743}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Stats (+3 lines, -46 lines)
M webrtc/voice_engine/include/voe_rtp_rtcp.h View 1 chunk +0 lines, -14 lines 0 comments
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 chunk +3 lines, -8 lines 0 comments
M webrtc/voice_engine/voe_rtp_rtcp_impl.h View 1 chunk +0 lines, -5 lines 0 comments
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 1 chunk +0 lines, -19 lines 0 comments

Messages

Total messages: 10 (4 generated)
kwiberg-webrtc
This one needs a PSA+deprecation cycle, because it modifies the public API.
4 years, 6 months ago (2016-06-09 12:08:50 UTC) #2
the sun
lgtm
4 years, 6 months ago (2016-06-13 08:23:27 UTC) #3
ossu
lgtm
4 years, 6 months ago (2016-06-14 15:43:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2055753002/60001
4 years, 4 months ago (2016-08-15 08:36:00 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-15 10:34:52 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 10:34:57 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0ccff57024c0b5f88fa10f177c6370b4e9447ce7
Cr-Commit-Position: refs/heads/master@{#13743}

Powered by Google App Engine