Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: webrtc/voice_engine/include/voe_rtp_rtcp.h

Issue 2055753002: VoERTP_RTCP: Remove GetREDStatus and SetREDStatus (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove-red
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 virtual int GetRTCPStatistics(int channel, CallStatistics& stats) = 0; 180 virtual int GetRTCPStatistics(int channel, CallStatistics& stats) = 0;
181 181
182 // Gets the report block parts of the last received RTCP Sender Report (SR), 182 // Gets the report block parts of the last received RTCP Sender Report (SR),
183 // or RTCP Receiver Report (RR) on a specified |channel|. Each vector 183 // or RTCP Receiver Report (RR) on a specified |channel|. Each vector
184 // element also contains the SSRC of the sender in addition to a report 184 // element also contains the SSRC of the sender in addition to a report
185 // block. 185 // block.
186 virtual int GetRemoteRTCPReportBlocks( 186 virtual int GetRemoteRTCPReportBlocks(
187 int channel, 187 int channel,
188 std::vector<ReportBlock>* receive_blocks) = 0; 188 std::vector<ReportBlock>* receive_blocks) = 0;
189 189
190 // Sets the Redundant Coding (RED) status on a specific |channel|.
191 // TODO(minyue): Make SetREDStatus() pure virtual when fakewebrtcvoiceengine
192 // in talk is ready.
193 virtual int SetREDStatus(int channel, bool enable, int redPayloadtype = -1) {
194 return -1;
195 }
196
197 // Gets the RED status on a specific |channel|.
198 // TODO(minyue): Make GetREDStatus() pure virtual when fakewebrtcvoiceengine
199 // in talk is ready.
200 virtual int GetREDStatus(int channel, bool& enabled, int& redPayloadtype) {
201 return -1;
202 }
203
204 // This function enables Negative Acknowledgment (NACK) using RTCP, 190 // This function enables Negative Acknowledgment (NACK) using RTCP,
205 // implemented based on RFC 4585. NACK retransmits RTP packets if lost on 191 // implemented based on RFC 4585. NACK retransmits RTP packets if lost on
206 // the network. This creates a lossless transport at the expense of delay. 192 // the network. This creates a lossless transport at the expense of delay.
207 // If using NACK, NACK should be enabled on both endpoints in a call. 193 // If using NACK, NACK should be enabled on both endpoints in a call.
208 virtual int SetNACKStatus(int channel, bool enable, int maxNoPackets) = 0; 194 virtual int SetNACKStatus(int channel, bool enable, int maxNoPackets) = 0;
209 195
210 protected: 196 protected:
211 VoERTP_RTCP() {} 197 VoERTP_RTCP() {}
212 virtual ~VoERTP_RTCP() {} 198 virtual ~VoERTP_RTCP() {}
213 }; 199 };
214 200
215 } // namespace webrtc 201 } // namespace webrtc
216 202
217 #endif // #ifndef WEBRTC_VOICE_ENGINE_VOE_RTP_RTCP_H 203 #endif // #ifndef WEBRTC_VOICE_ENGINE_VOE_RTP_RTCP_H
OLDNEW
« no previous file with comments | « no previous file | webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698