Remove RED support from WebRtcVoiceEngine/MediaChannel

Remove RED support from WebRtcVoiceEngine/MediaChannel

This CL was originally written by solenberg@webrtc.org:
https://codereview.webrtc.org/1928233003/

BUG=webrtc:4690, webrtc:5922
Committed: https://crrev.com/6806136aec983bd37911428abed712969b54a901
Cr-Commit-Position: refs/heads/master@{#13133}

[kwiberg-webrtc, 2016-06-09 12:06:47]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org, solenberg@webrtc.org

[the sun, 2016-06-13 08:14:21]

lgtm % tiny improvement.

https://codereview.webrtc.org/2051073002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2051073002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:401: if (!ToCodecInst(codec,
&voe_codec)) {
ToCodecInst() is well-behaved and doesn't modify the output parameter unless it
returns successfully, so we can use "out" directly in this call and avoid the
extra copy.

[kwiberg-webrtc, 2016-06-13 09:49:40]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-06-13 09:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051073002/1

[kwiberg-webrtc, 2016-06-13 09:50:05]

https://codereview.webrtc.org/2051073002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2051073002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:401: if (!ToCodecInst(codec,
&voe_codec)) {
On 2016/06/13 08:14:21, the sun wrote:
> ToCodecInst() is well-behaved and doesn't modify the output parameter unless
it
> returns successfully, so we can use "out" directly in this call and avoid the
> extra copy.

Sure. Separate CL forthcoming (because the change you request isn't really
related to this CL).

[commit-bot: I haz the power, 2016-06-13 09:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 09:53:38]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14123)

[kwiberg-webrtc, 2016-06-13 10:00:18]

kwiberg@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[kwiberg-webrtc, 2016-06-13 10:00:18]

Tina: Can you review the change in 	webrtc/audio_send_stream.h?

[tlegrand-webrtc, 2016-06-13 10:44:13]

On 2016/06/13 10:00:18, kwiberg-webrtc wrote:
> Tina: Can you review the change in 	webrtc/audio_send_stream.h?

LGTM for webrtc/audio_send_stream.h.

[kwiberg-webrtc, 2016-06-13 11:02:40]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-06-13 11:02:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051073002/1

[commit-bot: I haz the power, 2016-06-13 11:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 11:14:10]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14134)

[kwiberg-webrtc, 2016-06-14 13:57:25]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-06-14 13:57:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, tina.legrand@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2051073002/#ps20001 (title:
"rebase")

[commit-bot: I haz the power, 2016-06-14 13:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051073002/20001

[commit-bot: I haz the power, 2016-06-14 15:04:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-14 15:05:01]

Description was changed from

==========
Remove RED support from WebRtcVoiceEngine/MediaChannel

This CL was originally written by solenberg@webrtc.org:
https://codereview.webrtc.org/1928233003/

BUG=webrtc:4690, webrtc:5922
==========

to

==========
Remove RED support from WebRtcVoiceEngine/MediaChannel

This CL was originally written by solenberg@webrtc.org:
https://codereview.webrtc.org/1928233003/

BUG=webrtc:4690, webrtc:5922

Committed: https://crrev.com/6806136aec983bd37911428abed712969b54a901
Cr-Commit-Position: refs/heads/master@{#13133}
==========

[commit-bot: I haz the power, 2016-06-14 15:05:02]

Patchset 2 (id:??) landed as
https://crrev.com/6806136aec983bd37911428abed712969b54a901
Cr-Commit-Position: refs/heads/master@{#13133}