Chromium Code Reviews

Issue 2066473002: RtpRtcp: Remove the SetSendREDPayloadType and SendREDPayloadType methods (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-red3
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtpRtcp: Remove the SetSendREDPayloadType and SendREDPayloadType methods The last in-tree call site recently disappeared, so they were unused. BUG=webrtc:5922 Committed: https://crrev.com/963be23e629bbe5cc0c04e5441ec2ce6e8e0e425 Cr-Commit-Position: refs/heads/master@{#13751}

Patch Set 1 : RtpRtcp: Remove the SetSendREDPayloadType and SendREDPayloadType methods #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Stats (+13 lines, -233 lines)
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +0 lines, -8 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +0 lines, -6 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +0 lines, -11 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +0 lines, -6 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +0 lines, -24 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +0 lines, -8 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 5 chunks +13 lines, -97 lines 0 comments
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +0 lines, -73 lines 0 comments

Messages

Total messages: 13 (6 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-06-13 12:31:47 UTC) #3
kwiberg-webrtc
Switching to a reviewer who's actually an OWNER.
4 years, 6 months ago (2016-06-13 12:33:27 UTC) #5
hlundin-webrtc
lgtm
4 years, 6 months ago (2016-06-14 11:50:12 UTC) #6
hlundin-webrtc
On 2016/06/14 11:50:12, hlundin-webrtc wrote: > lgtm ... but you will have to send out ...
4 years, 6 months ago (2016-06-14 11:50:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2066473002/40001
4 years, 4 months ago (2016-08-15 13:17:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-15 14:08:33 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 14:08:45 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/963be23e629bbe5cc0c04e5441ec2ce6e8e0e425
Cr-Commit-Position: refs/heads/master@{#13751}

Powered by Google App Engine