RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
Committed: https://crrev.com/f9da44dbcf3f42a7361688f88c8fcf8f9d237781
Cr-Commit-Position: refs/heads/master@{#13089}

[hbos, 2016-06-02 14:18:36]

Description was changed from

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL...
- Turns nativeConfiguration into createNativeConfiguration returning a pointer
  or nil on failure. This method's certificate generation is updated to use the
  new API and reports failure (nil) if unsuccessful instead of relying on the
  default certificate. We also remove the implicit assumption (now incorrect)
  that RSA is the default. (FYI ECDSA is the new default.)
- With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
- Minor changes like adding or removing #include, etc.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Removed unnecessary #include still remnant due to indirect include of
kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

[hbos, 2016-06-02 14:21:07]

Patchset #1 (id:1) has been deleted

[hbos, 2016-06-02 14:23:16]

Description was changed from

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Removed unnecessary #include still remnant due to indirect include of
kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

[hbos, 2016-06-02 14:35:16]

hbos@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[hbos, 2016-06-02 14:35:17]

Please take a look, tkchin.

[hbos, 2016-06-03 22:27:43]

Bump tkchin, PTAL :)

[tkchin_webrtc, 2016-06-03 23:36:41]

some nits

lgtm

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h (right):

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h:37: +
(rtc::KeyType)nativeEncryptionKeyTypeForKeyType:(RTCEncryptionKeyType)keyType;
static methods before instance methods

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnectionInterface.mm (right):

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnectionInterface.mm:111: return nil;
nil isn't appropriate since the type is a C++ object. nullptr

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h (right):

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h:46: +
(rtc::KeyType)nativeEncryptionKeyTypeForKeyType:(RTCEncryptionKeyType)keyType;
nit: seems oddly placed? (breaks up tcpCandidatePolicy)
maybe place after stringForTcpCandidatePolicy

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right):

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:113: return nil;
ditto nullptr since webrtc::PeerConnectionInterface::RTCConfiguration * is a C++
object

[hbos, 2016-06-05 11:08:53]

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h (right):

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h:37: +
(rtc::KeyType)nativeEncryptionKeyTypeForKeyType:(RTCEncryptionKeyType)keyType;
On 2016/06/03 23:36:40, tkchin_webrtc wrote:
> static methods before instance methods 

Done.

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnectionInterface.mm (right):

https://codereview.webrtc.org/2035473004/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnectionInterface.mm:111: return nil;
On 2016/06/03 23:36:40, tkchin_webrtc wrote:
> nil isn't appropriate since the type is a C++ object. nullptr

Done.

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h (right):

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h:46: +
(rtc::KeyType)nativeEncryptionKeyTypeForKeyType:(RTCEncryptionKeyType)keyType;
On 2016/06/03 23:36:40, tkchin_webrtc wrote:
> nit: seems oddly placed? (breaks up tcpCandidatePolicy)
> maybe place after stringForTcpCandidatePolicy

Done. Moved in .mm file as well.

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right):

https://codereview.webrtc.org/2035473004/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:113: return nil;
On 2016/06/03 23:36:40, tkchin_webrtc wrote:
> ditto nullptr since webrtc::PeerConnectionInterface::RTCConfiguration * is a
C++
> object

Done.

[hbos, 2016-06-05 11:08:59]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-06-05 11:09:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2035473004/#ps60001 (title:
"Addressed nits")

[commit-bot: I haz the power, 2016-06-05 11:09:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035473004/60001

[commit-bot: I haz the power, 2016-06-05 11:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-05 11:11:13]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/11922)

[hbos, 2016-06-05 11:17:01]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-06-05 11:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2035473004/#ps80001 (title:
"Rebase with master")

[commit-bot: I haz the power, 2016-06-05 11:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035473004/80001

[commit-bot: I haz the power, 2016-06-05 11:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-05 11:34:38]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6093)

[hbos, 2016-06-09 09:43:48]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-06-09 09:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2035473004/#ps100001 (title:
"Fixed presubmit warnings (lines longer than)")

[commit-bot: I haz the power, 2016-06-09 09:43:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035473004/100001

[commit-bot: I haz the power, 2016-06-09 10:18:33]

Description was changed from

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

[commit-bot: I haz the power, 2016-06-09 10:18:34]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-06-09 10:18:38]

Description was changed from

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

This CL turns nativeConfiguration into createNativeConfiguration returning a
pointer or nil on failure. This method's certificate generation is updated to
use the new API and reports failure (nil) if unsuccessful instead of relying on
the default certificate. We also remove the implicit assumption (now incorrect)
that RSA is the default. This is the same type of changes as was done in
https://codereview.webrtc.org/1965313002 but this file
(RTCPeerConnectionInterface.mm) was forgotten.

With no more usages of kIdentityName it and dtlsidentitystore.cc is removed.
Also removes unnecessary #include in peerconnectioninterface.h that was still
remnant due to an indirect include of kIdentityName.

RTCConfiguration+Private.h now lists method nativeEncryptionKeyTypeForKeyType
which was added in the above mentioned prior CL.

BUG=webrtc:5707, webrtc:5708

Committed: https://crrev.com/f9da44dbcf3f42a7361688f88c8fcf8f9d237781
Cr-Commit-Position: refs/heads/master@{#13089}
==========

[commit-bot: I haz the power, 2016-06-09 10:18:39]

Patchset 5 (id:??) landed as
https://crrev.com/f9da44dbcf3f42a7361688f88c8fcf8f9d237781
Cr-Commit-Position: refs/heads/master@{#13089}