Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: talk/app/webrtc/objc/RTCPeerConnectionFactory.mm

Issue 2035473004: RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed presubmit warnings (lines longer than) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/objc/RTCPeerConnection.mm ('k') | talk/app/webrtc/objc/RTCPeerConnectionInterface.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/objc/RTCPeerConnectionFactory.mm
diff --git a/talk/app/webrtc/objc/RTCPeerConnectionFactory.mm b/talk/app/webrtc/objc/RTCPeerConnectionFactory.mm
index c156df74a5c7a47fcb1967517979df9b7754b8d5..13afa8da236f013e0bbcf28f72bbe0bb5c295a3f 100644
--- a/talk/app/webrtc/objc/RTCPeerConnectionFactory.mm
+++ b/talk/app/webrtc/objc/RTCPeerConnectionFactory.mm
@@ -99,8 +99,13 @@
- (RTCPeerConnection *)peerConnectionWithConfiguration:(RTCConfiguration *)configuration
constraints:(RTCMediaConstraints *)constraints
delegate:(id<RTCPeerConnectionDelegate>)delegate {
+ std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration> config(
+ [configuration createNativeConfiguration]);
+ if (!config) {
+ return nil;
+ }
return [[RTCPeerConnection alloc] initWithFactory:self.nativeFactory.get()
- config:configuration.nativeConfiguration
+ config:*config
constraints:constraints.constraints
delegate:delegate];
}
« no previous file with comments | « talk/app/webrtc/objc/RTCPeerConnection.mm ('k') | talk/app/webrtc/objc/RTCPeerConnectionInterface.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698