RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

webrtc/api/dtlsidentitystore.h

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_API_DTLSIDENTITYSTORE_H_
 #define WEBRTC_API_DTLSIDENTITYSTORE_H_
 
 #include <memory>
 #include <queue>
 #include <string>
 #include <utility>
 
 #include "webrtc/base/messagehandler.h"
 #include "webrtc/base/messagequeue.h"
 #include "webrtc/base/optional.h"
 #include "webrtc/base/refcount.h"
 #include "webrtc/base/rtccertificategenerator.h"
 #include "webrtc/base/scoped_ref_ptr.h"
 #include "webrtc/base/sslidentity.h"
 #include "webrtc/base/thread.h"
 
 namespace webrtc {
 
-// TODO(hbos): Remove this constant (and dtlsidentitystore.cc) after
-// RTCPeerConnectionInterface.mm stops using it.
-// bugs.webrtc.org/5707, bugs.webrtc.org/5708
-extern const char kIdentityName[];
-
 class SSLIdentity;
 class Thread;
 
 // Used to receive callbacks of DTLS identity requests.
 class DtlsIdentityRequestObserver : public rtc::RefCountInterface {
  public:
   virtual void OnFailure(int error) = 0;
   // TODO(hbos): Unify the OnSuccess method once Chrome code is updated.
   virtual void OnSuccess(const std::string& der_cert,
                          const std::string& der_private_key) = 0;
@@ skipping 17 matching lines @@
   // identity generation fails.
   virtual void RequestIdentity(
       const rtc::KeyParams& key_params,
       const rtc::Optional<uint64_t>& expires_ms,
       const rtc::scoped_refptr<DtlsIdentityRequestObserver>& observer) = 0;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_DTLSIDENTITYSTORE_H_