RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 92 matching lines @@
       _iceBackupCandidatePairPingInterval;
   rtc::KeyType keyType =
       [[self class] nativeEncryptionKeyTypeForKeyType:_keyType];
   // Generate non-default certificate.
   if (keyType != rtc::KT_DEFAULT) {
     rtc::scoped_refptr<rtc::RTCCertificate> certificate =
         rtc::RTCCertificateGenerator::GenerateCertificate(
             rtc::KeyParams(keyType), rtc::Optional<uint64_t>());
     if (!certificate) {
       RTCLogError(@"Failed to generate certificate.");
-      return nullptr;
+      return nil;

[tkchin_webrtc, 2016/06/03 23:36:40]

ditto nullptr since webrtc::PeerConnectionInterface::RTCConfiguration * is a C++
object

[hbos, 2016/06/05 11:08:53]

Done.

     }
     nativeConfig->certificates.push_back(certificate);
   }
   nativeConfig->ice_candidate_pool_size = _iceCandidatePoolSize;
 
   return nativeConfig.release();
 }
 
 + (webrtc::PeerConnectionInterface::IceTransportsType)
     nativeTransportsTypeForTransportPolicy:(RTCIceTransportPolicy)policy {
@@ skipping 164 matching lines @@
     (RTCContinualGatheringPolicy)policy {
   switch (policy) {
     case RTCContinualGatheringPolicyGatherOnce:
       return @"GATHER_ONCE";
     case RTCContinualGatheringPolicyGatherContinually:
       return @"GATHER_CONTINUALLY";
   }
 }
 
 @end