Remove use of RtpHeaderExtension and clean up

Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG=webrtc:5895
Committed: https://crrev.com/6f8d686d3503aafa64a8b545f8b8fdff65e8f816
Cr-Commit-Position: refs/heads/master@{#12924}

[Irfan, 2016-05-17 06:45:06]

Description was changed from

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

to

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

[Irfan, 2016-05-17 06:45:06]

isheriff@chromium.org changed reviewers:
+ perkj@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

[Irfan, 2016-05-17 06:46:54]

See config.h/config.cc for the modified RtpExtension
See mediachannel.h/mediaconstants.h for the removed RtpHeaderExtension and
constants. Much of rest of code is find and replace.

PTAL. Needs more testing, but I figured it is better to get early feedback due
to time difference for you guys.

[Irfan, 2016-05-17 17:25:50]

Patchset #2 (id:20001) has been deleted

[danilchap, 2016-05-17 18:07:14]

danilchap@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2016-05-17 18:07:15]

looks good: less same structures is better.

I'm sorry for beeing slow with cleanup of rtp header extensions (webrtc:1994).
I've created new structures for them with intention to concentrate all rtp
header extension specific code there, inside rtp_rtcp module, in
rtp_header_extensions.h/.cc files.
But still didn't clean any old code.

https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h
File webrtc/config.h (right):

https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h#newcode65
webrtc/config.h:65: static const int kAudioLevelId;
Ids are decided at runtime, so probably shouldn't create static consts for them.
or name those constants DefaultId (to be used when extensions are proposed or in
tests).

[Irfan, 2016-05-17 18:13:39]

https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h
File webrtc/config.h (right):

https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h#newcode65
webrtc/config.h:65: static const int kAudioLevelId;
On 2016/05/17 18:07:15, danilchap wrote:
> Ids are decided at runtime, so probably shouldn't create static consts for
them.
> or name those constants DefaultId (to be used when extensions are proposed or
in
> tests).
> 


These constants are defining values for specific extensions. As far as I could
see, the IDs for these defined extensions do not change at run time or am I
mistaken ? It appeared tests were the only place they were being modified ?

[danilchap, 2016-05-18 07:32:15]

On 2016/05/17 18:13:39, Irfan wrote:
> https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h
> File webrtc/config.h (right):
> 
> https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h#newcode65
> webrtc/config.h:65: static const int kAudioLevelId;
> On 2016/05/17 18:07:15, danilchap wrote:
> > Ids are decided at runtime, so probably shouldn't create static consts for
> them.
> > or name those constants DefaultId (to be used when extensions are proposed
or
> in
> > tests).
> > 
> 
> 
> These constants are defining values for specific extensions. As far as I could
> see, the IDs for these defined extensions do not change at run time or am I
> mistaken ? It appeared tests were the only place they were being modified ?

They can't be constant on receive side since sender define them.
Sender might be different implementation of webrtc.
ParseExtmap from webrtc/api/webrtcsdp.cc get the IDs from incoming string.

[pbos-webrtc, 2016-05-18 10:44:31]

On 2016/05/18 07:32:15, danilchap wrote:
> On 2016/05/17 18:13:39, Irfan wrote:
> > https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h
> > File webrtc/config.h (right):
> > 
> > https://codereview.webrtc.org/1984983002/diff/1/webrtc/config.h#newcode65
> > webrtc/config.h:65: static const int kAudioLevelId;
> > On 2016/05/17 18:07:15, danilchap wrote:
> > > Ids are decided at runtime, so probably shouldn't create static consts for
> > them.
> > > or name those constants DefaultId (to be used when extensions are proposed
> or
> > in
> > > tests).
> > > 
> > 
> > 
> > These constants are defining values for specific extensions. As far as I
could
> > see, the IDs for these defined extensions do not change at run time or am I
> > mistaken ? It appeared tests were the only place they were being modified ?
> 
> They can't be constant on receive side since sender define them.
> Sender might be different implementation of webrtc.
> ParseExtmap from webrtc/api/webrtcsdp.cc get the IDs from incoming string.

kRtpTimestampOffsetHeaderExtensionDefaultId for instance are used to populate
the default offer, it's not at all hard-coded final values and they are not
standardized.

[Irfan, 2016-05-18 18:01:47]

I cherry-picked this and tested on chrome with apprtc.

Let me know if there is anything else you would like me to do here.

[Irfan, 2016-05-18 18:02:13]

The CQ bit was checked by isheriff@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 18:02:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/60001

[commit-bot: I haz the power, 2016-05-18 18:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 18:02:21]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[danilchap, 2016-05-18 20:00:09]

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/config.cc
File webrtc/config.cc (right):

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/config.cc#newcode27
webrtc/config.cc:27: ss << "{uri: " << uri;
question to expirienced authors of the webrtc: Is this name used somewhere
externally?

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcmediaengine.cc (right):

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcmediaengine.cc:118: result.push_back({extension.uri,
extension.id});
thanks to unifying two structures this line could be simplified to
result.push_back(extension);

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/pc/channel.cc#newc...
webrtc/pc/channel.cc:49: inline const webrtc::RtpExtension FindHeaderExtension(
why changing function signature and returning copy of the extension instead of
const pointer?

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/pc/channel.cc#newc...
webrtc/pc/channel.cc:49: inline const webrtc::RtpExtension FindHeaderExtension(
no need for inline inside .cc

https://codereview.webrtc.org/1984983002/diff/60001/webrtc/pc/channel.cc#newc...
webrtc/pc/channel.cc:52: for (auto extension : extensions) {
const auto& to avoid unnecessary copy (and beeing able to return const pointer)

[Irfan, 2016-05-19 00:56:22]

https://codereview.chromium.org/1984983002/diff/60001/webrtc/media/engine/web...
File webrtc/media/engine/webrtcmediaengine.cc (right):

https://codereview.chromium.org/1984983002/diff/60001/webrtc/media/engine/web...
webrtc/media/engine/webrtcmediaengine.cc:118: result.push_back({extension.uri,
extension.id});
On 2016/05/18 20:00:09, danilchap wrote:
> thanks to unifying two structures this line could be simplified to
> result.push_back(extension);

Done.

https://codereview.chromium.org/1984983002/diff/60001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.chromium.org/1984983002/diff/60001/webrtc/pc/channel.cc#ne...
webrtc/pc/channel.cc:49: inline const webrtc::RtpExtension FindHeaderExtension(
On 2016/05/18 20:00:09, danilchap wrote:
> no need for inline inside .cc

Done.

https://codereview.chromium.org/1984983002/diff/60001/webrtc/pc/channel.cc#ne...
webrtc/pc/channel.cc:52: for (auto extension : extensions) {
On 2016/05/18 20:00:09, danilchap wrote:
> const auto& to avoid unnecessary copy (and beeing able to return const
pointer)

Done.

[Stefan, 2016-05-19 10:24:28]

holmer@chromium.org changed reviewers:
+ holmer@chromium.org

[Stefan, 2016-05-19 10:24:28]

lgtm

[danilchap, 2016-05-19 12:08:55]

lgtm

https://codereview.webrtc.org/1984983002/diff/80001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/80001/webrtc/pc/channel.cc#newc...
webrtc/pc/channel.cc:48: // empty extension otherwise.
nullptr otherwise.

[Irfan, 2016-05-19 15:01:28]

The CQ bit was checked by isheriff@chromium.org

[Irfan, 2016-05-19 15:01:29]

The patchset sent to the CQ was uploaded after l-g-t-m from holmer@chromium.org,
danilchap@webrtc.org
Link to the patchset: https://codereview.chromium.org/1984983002/#ps100001
(title: "Fixed nit")

[commit-bot: I haz the power, 2016-05-19 15:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/100001

[commit-bot: I haz the power, 2016-05-19 15:08:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 15:08:41]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5661)

[Irfan, 2016-05-19 15:13:40]

isheriff@chromium.org changed reviewers:
+ pthatcher@webrtc.org

[Irfan, 2016-05-19 15:14:05]

ptatcher, I need a owners LGTM. Thanks!

[perkj_webrtc, 2016-05-19 16:40:59]

lgtm with the below addressed. But it might still be good to get approvals for
pthatcher.

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/config.h
File webrtc/config.h (right):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/config.h#newcode64
webrtc/config.h:64: static const char* kAudioLevelUri;
please add the links to the description that you removed here.

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/media/base/mediac...
File webrtc/media/base/mediaconstants.h (left):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/media/base/mediac...
webrtc/media/base/mediaconstants.h:122: extern const int
kRtpAudioLevelHeaderExtensionDefaultId;
Can you please add these descriptions to config.h

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:46: #if defined(ENABLE_EXTERNAL_AUTH)
it does not look like you need this ifdef here? or do you get an unused error?

[Irfan, 2016-05-19 16:54:58]

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/config.h
File webrtc/config.h (right):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/config.h#newcode64
webrtc/config.h:64: static const char* kAudioLevelUri;
On 2016/05/19 16:40:59, perkj_webrtc wrote:
> please add the links to the description that you removed here. 

Done.

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/media/base/mediac...
File webrtc/media/base/mediaconstants.h (left):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/media/base/mediac...
webrtc/media/base/mediaconstants.h:122: extern const int
kRtpAudioLevelHeaderExtensionDefaultId;
On 2016/05/19 16:40:59, perkj_webrtc wrote:
> Can you please add these descriptions to config.h

Done.

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/100001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:46: #if defined(ENABLE_EXTERNAL_AUTH)
On 2016/05/19 16:40:59, perkj_webrtc wrote:
> it does not look like you need this ifdef here? or do you get an unused error?


yes

[Irfan, 2016-05-19 16:56:29]

ok will wait for pthatcher@ to take a look

[pthatcher1, 2016-05-25 20:43:31]

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc#...
webrtc/api/webrtcsdp.cc:30: #include "webrtc/config.h"
Can you leave a  "// for RtpExtension"?  Otherwise, it's not obvious what this
is for.

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc#...
webrtc/api/webrtcsdp.cc:68: using cricket::RtpHeaderExtensions;
Why do we bother with this any more instead of just using
std::vector<RtpExtension>?

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:57: }
Why the ifdef?

[Irfan, 2016-05-25 20:55:50]

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc#...
webrtc/api/webrtcsdp.cc:30: #include "webrtc/config.h"
On 2016/05/25 20:43:30, pthatcher1 wrote:
> Can you leave a  "// for RtpExtension"?  Otherwise, it's not obvious what this
> is for.

Done.

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/api/webrtcsdp.cc#...
webrtc/api/webrtcsdp.cc:68: using cricket::RtpHeaderExtensions;
On 2016/05/25 20:43:30, pthatcher1 wrote:
> Why do we bother with this any more instead of just using
> std::vector<RtpExtension>?

I removed the duplicate typedef in this file. RtpHeaderExtensions is defined in
pc/mediachannel.h and used in a bunch of places.

Agree that vector is clear enough - this pattern exists for a bunch of other
typedefs and perhaps deserves a separate clean up if we prefer that.

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1984983002/diff/120001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:57: }
On 2016/05/25 20:43:31, pthatcher1 wrote:
> Why the ifdef?

This method only gets invoked when ENABLE_EXTERNAL_AUTH is enabled. Having it
defined and unused leads to complaints from the compiler.

[Irfan, 2016-05-25 21:01:59]

Description was changed from

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

to

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:bot1,bot2;tryserver.chromium.mac:bot3
==========

[Irfan, 2016-05-25 21:02:35]

Addressed nit

[Irfan, 2016-05-25 21:03:16]

The CQ bit was checked by isheriff@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 21:03:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/140001

[commit-bot: I haz the power, 2016-05-25 21:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:04:13]

Dry run: Try jobs failed on following builders:
  bot3 on tryserver.chromium.mac (JOB_FAILED, no build URL)

[Irfan, 2016-05-25 21:56:07]

The CQ bit was checked by isheriff@chromium.org

[Irfan, 2016-05-25 21:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
danilchap@webrtc.org, holmer@chromium.org, perkj@webrtc.org
Link to the patchset: https://codereview.chromium.org/1984983002/#ps140001
(title: "Addressed nit")

[commit-bot: I haz the power, 2016-05-25 21:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/140001

[commit-bot: I haz the power, 2016-05-25 21:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:56:49]

Try jobs failed on following builders:
  bot1 on tryserver.chromium.linux (JOB_FAILED, no build URL)
  bot2 on tryserver.chromium.linux (JOB_FAILED, no build URL)
  bot3 on tryserver.chromium.mac (JOB_FAILED, no build URL)

[Irfan, 2016-05-25 21:57:15]

Description was changed from

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:bot1,bot2;tryserver.chromium.mac:bot3
==========

to

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

[Irfan, 2016-05-25 21:57:23]

The CQ bit was checked by isheriff@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/140001

[commit-bot: I haz the power, 2016-05-25 21:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:59:39]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5859)

[Irfan, 2016-05-25 22:01:28]

I need the LGTMs here again :)

[Irfan, 2016-05-26 17:31:57]

isheriff@chromium.org changed reviewers:
+ mflodman@webrtc.org

[Irfan, 2016-05-26 17:33:08]

Needs owner LGTM for:

    webrtc/audio
    webrtc/call
    webrtc/
    webrtc/video

Magnus, can you help ?

[pthatcher1, 2016-05-26 17:37:56]

lgtm

[Irfan, 2016-05-26 17:40:18]

The CQ bit was checked by isheriff@chromium.org

[commit-bot: I haz the power, 2016-05-26 17:40:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/140001

[commit-bot: I haz the power, 2016-05-26 17:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 17:43:55]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5888)

[mflodman, 2016-05-26 18:08:18]

LGTM!

[Irfan, 2016-05-26 18:09:23]

The CQ bit was checked by isheriff@chromium.org

[commit-bot: I haz the power, 2016-05-26 18:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984983002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984983002/140001

[commit-bot: I haz the power, 2016-05-26 18:25:00]

Description was changed from

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

to

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

[commit-bot: I haz the power, 2016-05-26 18:25:03]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-05-26 18:25:12]

Description was changed from

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895
==========

to

==========
Remove use of RtpHeaderExtension and clean up

Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension

The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.

Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.

BUG= webrtc:5895

Committed: https://crrev.com/6f8d686d3503aafa64a8b545f8b8fdff65e8f816
Cr-Commit-Position: refs/heads/master@{#12924}
==========

[commit-bot: I haz the power, 2016-05-26 18:25:14]

Patchset 7 (id:??) landed as
https://crrev.com/6f8d686d3503aafa64a8b545f8b8fdff65e8f816
Cr-Commit-Position: refs/heads/master@{#12924}

[the sun, 2016-05-30 16:00:15]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-05-30 16:00:17]

lgtm

https://codereview.chromium.org/1984983002/diff/140001/webrtc/pc/mediasession.h
File webrtc/pc/mediasession.h (right):

https://codereview.chromium.org/1984983002/diff/140001/webrtc/pc/mediasession...
webrtc/pc/mediasession.h:38: typedef std::vector<webrtc::RtpExtension>
RtpHeaderExtensions;
Is this actually used anywhere? ...

https://codereview.chromium.org/1984983002/diff/140001/webrtc/pc/mediasession...
webrtc/pc/mediasession.h:287: std::vector<webrtc::RtpExtension>
rtp_header_extensions_;
...it could be used here.