|
Remove use of RtpHeaderExtension and clean up
Currently there are two structs that are identical and track extension details:
webrtc::RtpExtension
cricket::RtpHeaderExtension
The use of the structs is mixed in the code to track the extensions being
supported. This results in duplicate definition of
the URI constants and there is code to convert between the two structs.
Clean up to use a single RtpHeader throughout the codebase. The actual location
of RtpHeader may change in future (perhaps to be located in api/). Additionally,
this CL renames some of the constants to clarify Uri and Id use.
BUG= webrtc:5895
Committed: https://crrev.com/6f8d686d3503aafa64a8b545f8b8fdff65e8f816
Cr-Commit-Position: refs/heads/master@{#12924}
Total comments: 2
Total comments: 8
Total comments: 1
Total comments: 6
Total comments: 6
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+433 lines, -504 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
webrtc/api/webrtcsdp.cc
|
View
|
1
2
3
4
5
6
|
8 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/webrtcsdp_unittest.cc
|
View
|
|
4 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/audio/audio_receive_stream.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/audio/audio_receive_stream_unittest.cc
|
View
|
1
3
4
5
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/audio/audio_send_stream.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/audio/audio_send_stream_unittest.cc
|
View
|
1
3
4
5
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/call/bitrate_estimator_tests.cc
|
View
|
|
8 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/call/rampup_tests.cc
|
View
|
|
5 chunks |
+32 lines, -30 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/call/rtc_event_log.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/call/rtc_event_log_unittest.cc
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/call/rtc_event_log_unittest_helper.cc
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/config.h
|
View
|
1
2
3
4
5
|
1 chunk |
+33 lines, -11 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/config.cc
|
View
|
1
2
|
1 chunk |
+26 lines, -16 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/fakemediaengine.h
|
View
|
1
2
3
|
6 chunks |
+11 lines, -12 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/mediachannel.h
|
View
|
1
2
3
|
4 chunks |
+2 lines, -41 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/mediaconstants.h
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/mediaconstants.cc
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/mediaengine.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcmediaengine.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcmediaengine.cc
|
View
|
1
2
3
|
5 chunks |
+16 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcmediaengine_unittest.cc
|
View
|
|
4 chunks |
+48 lines, -54 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvideoengine2.cc
|
View
|
1
2
3
|
4 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvideoengine2_unittest.cc
|
View
|
1
2
3
|
25 chunks |
+72 lines, -84 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvoiceengine.cc
|
View
|
1
2
3
|
1 chunk |
+8 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvoiceengine_unittest.cc
|
View
|
1
2
3
|
11 chunks |
+19 lines, -22 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/channel.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/channel.cc
|
View
|
1
2
3
4
|
2 chunks |
+17 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/mediasession.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
2 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/mediasession.cc
|
View
|
|
5 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/mediasession_unittest.cc
|
View
|
1
2
3
|
5 chunks |
+34 lines, -38 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/test/call_test.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/end_to_end_tests.cc
|
View
|
1
2
3
4
5
6
|
7 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/replay.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/rtp_stream_receiver.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/video_quality_test.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/video_receive_stream.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/video_send_stream.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/video/video_send_stream_tests.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 64 (27 generated)
|