Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: webrtc/media/engine/webrtcmediaengine.h

Issue 1984983002: Remove use of RtpHeaderExtension and clean up (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 19 matching lines...) Expand all
30 class WebRtcMediaEngineFactory { 30 class WebRtcMediaEngineFactory {
31 public: 31 public:
32 static MediaEngineInterface* Create( 32 static MediaEngineInterface* Create(
33 webrtc::AudioDeviceModule* adm, 33 webrtc::AudioDeviceModule* adm,
34 WebRtcVideoEncoderFactory* encoder_factory, 34 WebRtcVideoEncoderFactory* encoder_factory,
35 WebRtcVideoDecoderFactory* decoder_factory); 35 WebRtcVideoDecoderFactory* decoder_factory);
36 }; 36 };
37 37
38 // Verify that extension IDs are within 1-byte extension range and are not 38 // Verify that extension IDs are within 1-byte extension range and are not
39 // overlapping. 39 // overlapping.
40 bool ValidateRtpExtensions(const std::vector<RtpHeaderExtension>& extensions); 40 bool ValidateRtpExtensions(const std::vector<webrtc::RtpExtension>& extensions);
41 41
42 // Convert cricket::RtpHeaderExtension:s to webrtc::RtpExtension:s, discarding 42 // Discard any extensions not validated by the 'supported' predicate. Duplicate
43 // any extensions not validated by the 'supported' predicate. Duplicate
44 // extensions are removed if 'filter_redundant_extensions' is set, and also any 43 // extensions are removed if 'filter_redundant_extensions' is set, and also any
45 // mutually exclusive extensions (see implementation for details). 44 // mutually exclusive extensions (see implementation for details) are removed.
46 std::vector<webrtc::RtpExtension> FilterRtpExtensions( 45 std::vector<webrtc::RtpExtension> FilterRtpExtensions(
47 const std::vector<RtpHeaderExtension>& extensions, 46 const std::vector<webrtc::RtpExtension>& extensions,
48 bool (*supported)(const std::string&), 47 bool (*supported)(const std::string&),
49 bool filter_redundant_extensions); 48 bool filter_redundant_extensions);
50 49
51 } // namespace cricket 50 } // namespace cricket
52 51
53 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCMEDIAENGINE_H_ 52 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCMEDIAENGINE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698