Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: webrtc/video/video_send_stream.cc

Issue 1984983002: Remove use of RtpHeaderExtension and clean up (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 414
415 // RTP/RTCP initialization. 415 // RTP/RTCP initialization.
416 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) { 416 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
417 module_process_thread_->RegisterModule(rtp_rtcp); 417 module_process_thread_->RegisterModule(rtp_rtcp);
418 congestion_controller_->packet_router()->AddRtpModule(rtp_rtcp); 418 congestion_controller_->packet_router()->AddRtpModule(rtp_rtcp);
419 } 419 }
420 420
421 video_sender_->RegisterProtectionCallback(this); 421 video_sender_->RegisterProtectionCallback(this);
422 422
423 for (size_t i = 0; i < config_.rtp.extensions.size(); ++i) { 423 for (size_t i = 0; i < config_.rtp.extensions.size(); ++i) {
424 const std::string& extension = config_.rtp.extensions[i].name; 424 const std::string& extension = config_.rtp.extensions[i].uri;
425 int id = config_.rtp.extensions[i].id; 425 int id = config_.rtp.extensions[i].id;
426 // One-byte-extension local identifiers are in the range 1-14 inclusive. 426 // One-byte-extension local identifiers are in the range 1-14 inclusive.
427 RTC_DCHECK_GE(id, 1); 427 RTC_DCHECK_GE(id, 1);
428 RTC_DCHECK_LE(id, 14); 428 RTC_DCHECK_LE(id, 14);
429 RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension)); 429 RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension));
430 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) { 430 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
431 RTC_CHECK_EQ(0, rtp_rtcp->RegisterSendRtpHeaderExtension( 431 RTC_CHECK_EQ(0, rtp_rtcp->RegisterSendRtpHeaderExtension(
432 StringToRtpExtensionType(extension), id)); 432 StringToRtpExtensionType(extension), id));
433 } 433 }
434 } 434 }
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 &module_nack_rate); 802 &module_nack_rate);
803 *sent_video_rate_bps += module_video_rate; 803 *sent_video_rate_bps += module_video_rate;
804 *sent_nack_rate_bps += module_nack_rate; 804 *sent_nack_rate_bps += module_nack_rate;
805 *sent_fec_rate_bps += module_fec_rate; 805 *sent_fec_rate_bps += module_fec_rate;
806 } 806 }
807 return 0; 807 return 0;
808 } 808 }
809 809
810 } // namespace internal 810 } // namespace internal
811 } // namespace webrtc 811 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698