Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: webrtc/config.h

Issue 1984983002: Remove use of RtpHeaderExtension and clean up (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/config.h
diff --git a/webrtc/config.h b/webrtc/config.h
index 06460ae359641a533c7fdc4615e51637e72fb2ba..d5fd1fe564f6ea2b7d8d93f8b8280ebe27e221f0 100644
--- a/webrtc/config.h
+++ b/webrtc/config.h
@@ -52,20 +52,42 @@ struct FecConfig {
// RTP header extension, see RFC 5285.
struct RtpExtension {
- RtpExtension(const std::string& name, int id) : name(name), id(id) {}
+ RtpExtension() : id(0) {}
+ RtpExtension(const std::string& uri, int id) : uri(uri), id(id) {}
std::string ToString() const;
bool operator==(const RtpExtension& rhs) const {
- return name == rhs.name && id == rhs.id;
+ return uri == rhs.uri && id == rhs.id;
}
- static bool IsSupportedForAudio(const std::string& name);
- static bool IsSupportedForVideo(const std::string& name);
-
- static const char* kTOffset;
- static const char* kAbsSendTime;
- static const char* kVideoRotation;
- static const char* kAudioLevel;
- static const char* kTransportSequenceNumber;
- std::string name;
+ static bool IsSupportedForAudio(const std::string& uri);
+ static bool IsSupportedForVideo(const std::string& uri);
+
+ // Header extension for audio levels, as defined in:
+ // http://tools.ietf.org/html/draft-ietf-avtext-client-to-mixer-audio-level-03
+ static const char* kAudioLevelUri;
+ static const int kAudioLevelDefaultId;
+
+ // Header extension for RTP timestamp offset, see RFC 5450 for details:
+ // http://tools.ietf.org/html/rfc5450
+ static const char* kTimestampOffsetUri;
+ static const int kTimestampOffsetDefaultId;
+
+ // Header extension for absolute send time, see url for details:
+ // http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
+ static const char* kAbsSendTimeUri;
+ static const int kAbsSendTimeDefaultId;
+
+ // Header extension for coordination of video orientation, see url for
+ // details:
+ // http://www.etsi.org/deliver/etsi_ts/126100_126199/126114/12.07.00_60/ts_126114v120700p.pdf
+ static const char* kVideoRotationUri;
+ static const int kVideoRotationDefaultId;
+
+ // Header extension for transport sequence number, see url for details:
+ // http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions
+ static const char* kTransportSequenceNumberUri;
+ static const int kTransportSequenceNumberDefaultId;
+
+ std::string uri;
int id;
};

Powered by Google App Engine
This is Rietveld 408576698