Add a parameter to set a maximum filesize when starting an RTC event log on the PeerConnectionFacto…

Add a parameter to set a maximum file size when starting an RTC event log on the PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=

Committed: https://crrev.com/c1513ee1a398ad0ed3b8cca985764cf70d6a7545
Cr-Commit-Position: refs/heads/master@{#12730}

[ivoc, 2016-05-11 16:32:50]

Description was changed from

==========
Add a parameter to set a maximum filesize when starting an RTC event log on the
PeerConnectionFactory API.


BUG=
==========

to

==========
Add a parameter to set a maximum filesize when starting an RTC event log on the
PeerConnectionFactory API.

BUG=
==========

[ivoc, 2016-05-11 16:32:51]

ivoc@webrtc.org changed reviewers:
+ mflodman@webrtc.org, stefan@webrtc.org, terelius@webrtc.org

[ivoc, 2016-05-11 16:32:51]

ivoc@webrtc.org changed required reviewers:
+ mflodman@webrtc.org

[ivoc, 2016-05-11 16:42:28]

Hey guys, here's the CL to add a maximum filesize parameter to the
PeerConnectionFactory API. Please have a look.

[terelius, 2016-05-12 08:39:12]

https://codereview.webrtc.org/1974453002/diff/1/webrtc/api/java/src/org/webrt...
File webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/1974453002/diff/1/webrtc/api/java/src/org/webrt...
webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java:168: public void
StopRtcEventLog() {
StopRtcEventLog -> stopRtcEventLog.

https://codereview.webrtc.org/1974453002/diff/1/webrtc/media/base/mediaengine.h
File webrtc/media/base/mediaengine.h (right):

https://codereview.webrtc.org/1974453002/diff/1/webrtc/media/base/mediaengine...
webrtc/media/base/mediaengine.h:96: // Starts RtcEventLog using existing file, a
maximum file size in bytes can be
I'd prefer changing the first sentence to
"Starts RtcEventLog using existing file and a maximum file size in bytes."
or
"Starts RtcEventLog using existing file. A maximum file size in bytes can be
specified."

[ivoc, 2016-05-12 09:05:03]

Description was changed from

==========
Add a parameter to set a maximum filesize when starting an RTC event log on the
PeerConnectionFactory API.

BUG=
==========

to

==========
Add a parameter to set a maximum file size when starting an RTC event log on the
PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=
==========

[ivoc, 2016-05-12 09:07:11]

https://codereview.webrtc.org/1974453002/diff/1/webrtc/api/java/src/org/webrt...
File webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/1974453002/diff/1/webrtc/api/java/src/org/webrt...
webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java:168: public void
StopRtcEventLog() {
On 2016/05/12 08:39:12, terelius wrote:
> StopRtcEventLog -> stopRtcEventLog.

Done.

https://codereview.webrtc.org/1974453002/diff/1/webrtc/media/base/mediaengine.h
File webrtc/media/base/mediaengine.h (right):

https://codereview.webrtc.org/1974453002/diff/1/webrtc/media/base/mediaengine...
webrtc/media/base/mediaengine.h:96: // Starts RtcEventLog using existing file, a
maximum file size in bytes can be
On 2016/05/12 08:39:12, terelius wrote:
> I'd prefer changing the first sentence to
> "Starts RtcEventLog using existing file and a maximum file size in bytes."
> or
> "Starts RtcEventLog using existing file. A maximum file size in bytes can be
> specified."

Good point, I went for option 2.

[stefan-webrtc, 2016-05-12 09:12:00]

lgtm

[terelius, 2016-05-12 09:18:41]

lgtm

[mflodman, 2016-05-13 12:04:53]

lgtm

https://codereview.webrtc.org/1974453002/diff/20001/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1974453002/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log.cc:202: bool
RtcEventLogImpl::StartLogging(rtc::PlatformFile platform_file,
There is a log of duplicated code between the different StartLogging methods. As
a followup by someone, to not block this CL and since it's mostly old code, it
would be very nice to break out the common parts into a common method.

I'm getting off topic, I'll send you and Björn an e-mail instead with questions.

[ivoc, 2016-05-13 12:45:15]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-05-13 12:45:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974453002/20001

[commit-bot: I haz the power, 2016-05-13 12:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 12:48:51]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13285)

[ivoc, 2016-05-13 13:02:02]

The CQ bit was checked by ivoc@webrtc.org

[ivoc, 2016-05-13 13:02:03]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org,
stefan@webrtc.org, mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1974453002/#ps40001 (title:
"Fixed typo in JNI code.")

[commit-bot: I haz the power, 2016-05-13 13:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974453002/40001

[commit-bot: I haz the power, 2016-05-13 15:30:44]

Description was changed from

==========
Add a parameter to set a maximum file size when starting an RTC event log on the
PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=
==========

to

==========
Add a parameter to set a maximum file size when starting an RTC event log on the
PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=
==========

[commit-bot: I haz the power, 2016-05-13 15:30:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 15:30:52]

Description was changed from

==========
Add a parameter to set a maximum file size when starting an RTC event log on the
PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=
==========

to

==========
Add a parameter to set a maximum file size when starting an RTC event log on the
PeerConnectionFactory API.

The caller can set a negative or zero file size to avoid using a limit.
BUG=

Committed: https://crrev.com/c1513ee1a398ad0ed3b8cca985764cf70d6a7545
Cr-Commit-Position: refs/heads/master@{#12730}
==========

[commit-bot: I haz the power, 2016-05-13 15:30:53]

Patchset 3 (id:??) landed as
https://crrev.com/c1513ee1a398ad0ed3b8cca985764cf70d6a7545
Cr-Commit-Position: refs/heads/master@{#12730}