Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 1974453002: Add a parameter to set a maximum filesize when starting an RTC event log on the PeerConnectionFacto… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed typo in JNI code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | webrtc/pc/channelmanager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1038 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 if (is_dumping_aec_) { 1049 if (is_dumping_aec_) {
1050 // Stop dumping AEC when we are dumping. 1050 // Stop dumping AEC when we are dumping.
1051 if (voe_wrapper_->base()->audio_processing()->StopDebugRecording() != 1051 if (voe_wrapper_->base()->audio_processing()->StopDebugRecording() !=
1052 webrtc::AudioProcessing::kNoError) { 1052 webrtc::AudioProcessing::kNoError) {
1053 LOG_RTCERR0(StopDebugRecording); 1053 LOG_RTCERR0(StopDebugRecording);
1054 } 1054 }
1055 is_dumping_aec_ = false; 1055 is_dumping_aec_ = false;
1056 } 1056 }
1057 } 1057 }
1058 1058
1059 bool WebRtcVoiceEngine::StartRtcEventLog(rtc::PlatformFile file) { 1059 bool WebRtcVoiceEngine::StartRtcEventLog(rtc::PlatformFile file,
1060 int64_t max_size_bytes) {
1060 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 1061 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
1061 webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog(); 1062 webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
1062 if (event_log) { 1063 if (event_log) {
1063 return event_log->StartLogging(file); 1064 return event_log->StartLogging(file, max_size_bytes);
1064 } 1065 }
1065 LOG_RTCERR0(StartRtcEventLog); 1066 LOG_RTCERR0(StartRtcEventLog);
1066 return false; 1067 return false;
1067 } 1068 }
1068 1069
1069 void WebRtcVoiceEngine::StopRtcEventLog() { 1070 void WebRtcVoiceEngine::StopRtcEventLog() {
1070 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 1071 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
1071 webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog(); 1072 webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
1072 if (event_log) { 1073 if (event_log) {
1073 event_log->StopLogging(); 1074 event_log->StopLogging();
(...skipping 1485 matching lines...) Expand 10 before | Expand all | Expand 10 after
2559 } 2560 }
2560 } else { 2561 } else {
2561 LOG(LS_INFO) << "Stopping playout for channel #" << channel; 2562 LOG(LS_INFO) << "Stopping playout for channel #" << channel;
2562 engine()->voe()->base()->StopPlayout(channel); 2563 engine()->voe()->base()->StopPlayout(channel);
2563 } 2564 }
2564 return true; 2565 return true;
2565 } 2566 }
2566 } // namespace cricket 2567 } // namespace cricket
2567 2568
2568 #endif // HAVE_WEBRTC_VOICE 2569 #endif // HAVE_WEBRTC_VOICE
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | webrtc/pc/channelmanager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698