Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java

Issue 1974453002: Add a parameter to set a maximum filesize when starting an RTC event log on the PeerConnectionFacto… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed typo in JNI code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/java/jni/peerconnection_jni.cc ('k') | webrtc/api/peerconnectionfactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java
diff --git a/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java b/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java
index 87fa55afcc00a11932981724b8667cf6ca9b46de..fef56ba34e153c5ff91c505ac68987c074eae367 100644
--- a/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java
+++ b/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java
@@ -151,12 +151,21 @@ public class PeerConnectionFactory {
// the native code. If an RTC event log is already being recorded, it will be
// stopped and a new one will start using the provided file.
public boolean startRtcEventLog(int file_descriptor) {
- return nativeStartRtcEventLog(nativeFactory, file_descriptor);
+ return startRtcEventLog(file_descriptor, -1);
+ }
+
+ // Same as above, but allows setting an upper limit to the size of the
+ // generated logfile.
+ public boolean startRtcEventLog(int file_descriptor,
+ int filesize_limit_bytes) {
+ return nativeStartRtcEventLog(nativeFactory,
+ file_descriptor,
+ filesize_limit_bytes);
}
// Stops recording an RTC event log. If no RTC event log is currently being
// recorded, this call will have no effect.
- public void StopRtcEventLog() {
+ public void stopRtcEventLog() {
nativeStopRtcEventLog(nativeFactory);
}
@@ -258,7 +267,9 @@ public class PeerConnectionFactory {
private static native void nativeStopAecDump(long nativeFactory);
- private static native boolean nativeStartRtcEventLog(long nativeFactory, int file_descriptor);
+ private static native boolean nativeStartRtcEventLog(long nativeFactory,
+ int file_descriptor,
+ int filesize_limit_bytes);
private static native void nativeStopRtcEventLog(long nativeFactory);
« no previous file with comments | « webrtc/api/java/jni/peerconnection_jni.cc ('k') | webrtc/api/peerconnectionfactory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698