Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: webrtc/media/base/mediaengine.h

Issue 1974453002: Add a parameter to set a maximum filesize when starting an RTC event log on the PeerConnectionFacto… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed typo in JNI code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/mediaengine.h
diff --git a/webrtc/media/base/mediaengine.h b/webrtc/media/base/mediaengine.h
index 4c7d62a1e4b7bc99503c3ce8885d4c80a276295a..4446bd6b0e4446c6d501e7e5c87d03794199e564 100644
--- a/webrtc/media/base/mediaengine.h
+++ b/webrtc/media/base/mediaengine.h
@@ -93,8 +93,11 @@ class MediaEngineInterface {
// Stops recording AEC dump.
virtual void StopAecDump() = 0;
- // Starts RtcEventLog using existing file.
- virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
+ // Starts RtcEventLog using existing file. A maximum file size in bytes can be
+ // specified. Logging is stopped just before the size limit is exceeded.
+ // If max_size_bytes is set to a value <= 0, no limit will be used.
+ virtual bool StartRtcEventLog(rtc::PlatformFile file,
+ int64_t max_size_bytes) = 0;
// Stops recording an RtcEventLog.
virtual void StopRtcEventLog() = 0;
@@ -176,8 +179,9 @@ class CompositeMediaEngine : public MediaEngineInterface {
voice_.StopAecDump();
}
- virtual bool StartRtcEventLog(rtc::PlatformFile file) {
- return voice_.StartRtcEventLog(file);
+ virtual bool StartRtcEventLog(rtc::PlatformFile file,
+ int64_t max_size_bytes) {
+ return voice_.StartRtcEventLog(file, max_size_bytes);
}
virtual void StopRtcEventLog() { voice_.StopRtcEventLog(); }
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698