Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1936173002: Changed the AEC SubbandCoherence function to not use the full aec state (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@RefactorAec1_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed the AEC SubbandCoherence function to not use the full AEC state This CL is step towards simplifying the AEC code, making it more modifiable and modular. The changes should be bitexact. BUG=webrtc:5201, webrtc:5298 Committed: https://crrev.com/8d13c4fe1a3e05e65ff1f8637cc7a097f42dde8c Cr-Commit-Position: refs/heads/master@{#12652}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -142 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 2 4 chunks +51 lines, -38 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 2 3 3 chunks +12 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 8 chunks +61 lines, -47 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 8 chunks +69 lines, -53 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
peah-webrtc
4 years, 7 months ago (2016-05-02 15:40:26 UTC) #3
ivoc
LGTM.
4 years, 7 months ago (2016-05-06 14:37:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936173002/40001
4 years, 7 months ago (2016-05-07 19:48:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/9054)
4 years, 7 months ago (2016-05-07 19:50:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936173002/60001
4 years, 7 months ago (2016-05-07 21:04:18 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-07 22:03:52 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 22:04:03 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8d13c4fe1a3e05e65ff1f8637cc7a097f42dde8c
Cr-Commit-Position: refs/heads/master@{#12652}

Powered by Google App Engine
This is Rietveld 408576698