Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1942853002: Removed the MIPS optimized code for the comfort noise generation in the AEC. (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@RefactorAec2_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed the MIPS optimized code for the comfort noise generation in theAEC. The reason for this is that this optimized method hinders any refactoring of the code. In particular, it is not possible to separate the application of the echo suppressor gain from the gain computation and the comfort noise generation as all of these are partly included in this method. This CL is step towards simplifying the AEC code, making it more modifiable and modular. The changes should be bitexact. BUG=webrtc:5201, webrtc:5298 Committed: https://crrev.com/779e97e49336e72930c51f2495a12cb99819b5ae Cr-Commit-Position: refs/heads/master@{#12653}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -309 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 2 chunks +0 lines, -299 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
peah-webrtc
4 years, 7 months ago (2016-05-02 16:13:14 UTC) #3
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-05-03 07:46:42 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1936173002 Patch 20001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-04 19:38:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942853002/20001
4 years, 7 months ago (2016-05-07 22:04:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-07 23:36:07 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 23:36:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/779e97e49336e72930c51f2495a12cb99819b5ae
Cr-Commit-Position: refs/heads/master@{#12653}

Powered by Google App Engine
This is Rietveld 408576698