Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1936203002: Made the method PartitionDelay independent of the AEC state. (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@RefactorAec3_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Made the method PartitionDelay independent of the AEC state. This CL is step towards simplifying the AEC code, making it more modifiable and modular. The changes should be bitexact. BUG=webrtc:5201, webrtc:5298 Committed: https://crrev.com/6c9b65ab3854a41ee67b9f9f76c0dc70f42b72df Cr-Commit-Position: refs/heads/master@{#12654}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
peah-webrtc
4 years, 7 months ago (2016-05-02 16:12:59 UTC) #3
ivoc
Nice, LGTM.
4 years, 7 months ago (2016-05-06 09:38:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936203002/20001
4 years, 7 months ago (2016-05-07 23:37:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-08 00:47:08 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-08 00:47:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c9b65ab3854a41ee67b9f9f76c0dc70f42b72df
Cr-Commit-Position: refs/heads/master@{#12654}

Powered by Google App Engine
This is Rietveld 408576698