Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1943193002: Broke apart the functionalities in the SubbandCoherence method in the AEC (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@RefactorAec4_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Broke apart the functionalities in the SubbandCoherence method in the AEC. This CL is step towards simplifying the AEC code, making it more modifiable and modular. The changes should be bitexact. BUG=webrtc:5201, webrtc:5298 Committed: https://crrev.com/23868b64bc1a0a3226011327bc079c1c67f6ea4b Cr-Commit-Position: refs/heads/master@{#12655}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Removed extra space in comment #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -86 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 2 6 chunks +22 lines, -31 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 1 chunk +13 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 3 chunks +12 lines, -22 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 3 chunks +12 lines, -22 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
peah-webrtc
4 years, 7 months ago (2016-05-03 05:10:32 UTC) #3
minyue-webrtc
lgtm https://codereview.webrtc.org/1943193002/diff/1/webrtc/modules/audio_processing/aec/aec_core.cc File webrtc/modules/audio_processing/aec/aec_core.cc (right): https://codereview.webrtc.org/1943193002/diff/1/webrtc/modules/audio_processing/aec/aec_core.cc#newcode406 webrtc/modules/audio_processing/aec/aec_core.cc:406: // Updates the following smoothed Power Spectral Densities ...
4 years, 7 months ago (2016-05-03 07:29:06 UTC) #4
peah-webrtc
https://codereview.webrtc.org/1943193002/diff/1/webrtc/modules/audio_processing/aec/aec_core.cc File webrtc/modules/audio_processing/aec/aec_core.cc (right): https://codereview.webrtc.org/1943193002/diff/1/webrtc/modules/audio_processing/aec/aec_core.cc#newcode406 webrtc/modules/audio_processing/aec/aec_core.cc:406: // Updates the following smoothed Power Spectral Densities (PSD): ...
4 years, 7 months ago (2016-05-07 21:26:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943193002/60001
4 years, 7 months ago (2016-05-08 07:47:03 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-08 08:50:22 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-08 08:50:29 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/23868b64bc1a0a3226011327bc079c1c67f6ea4b
Cr-Commit-Position: refs/heads/master@{#12655}

Powered by Google App Engine
This is Rietveld 408576698