Separated the functionalities in the OverdriveAndSuppress method in the AEC into two methods

Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it
more modifiable and modular.

The changes should be bitexact.

BUG=webrtc:5201, webrtc:5298
Committed: https://crrev.com/e69c37bc96f294e79eef4fea359ac8307d729a18
Cr-Commit-Position: refs/heads/master@{#12656}

[peah-webrtc, 2016-05-03 05:30:11]

Description was changed from

==========
Separated the functionalities in the OverdriveAndSuppress method in the AEC into
two methods

BUG=
==========

to

==========
Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it 
more modifiable and modular.

The changes should be bitexact.


BUG=webrtc:5201, webrtc:5298
==========

[peah-webrtc, 2016-05-03 05:30:11]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2016-05-03 05:30:30]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 05:30:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943753002/1

[commit-bot: I haz the power, 2016-05-03 05:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 05:32:28]

Dry run: Try jobs failed on following builders:
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/14697)

[hlundin-webrtc, 2016-05-03 08:22:29]

LGTM with one change.

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.cc:330: static void Suppress(float
hNl[PART_LEN1], float efw[2][PART_LEN1]) {
hNl should be const.

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core_internal.h (right):

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core_internal.h:233: typedef void
(*WebRtcAecSuppress)(float hNl[PART_LEN1],
hNl const here too. (And all other places that follows thereof.)

[peah-webrtc, 2016-05-07 21:26:15]

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.cc:330: static void Suppress(float
hNl[PART_LEN1], float efw[2][PART_LEN1]) {
On 2016/05/03 08:22:29, hlundin-webrtc wrote:
> hNl should be const.

Done.

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core_internal.h (right):

https://codereview.webrtc.org/1943753002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core_internal.h:233: typedef void
(*WebRtcAecSuppress)(float hNl[PART_LEN1],
On 2016/05/03 08:22:29, hlundin-webrtc wrote:
> hNl const here too. (And all other places that follows thereof.)

Done.

[peah-webrtc, 2016-05-08 08:54:12]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-05-08 08:54:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1943753002/#ps80001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-05-08 08:54:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943753002/80001

[commit-bot: I haz the power, 2016-05-08 09:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-08 09:04:35]

Try jobs failed on following builders:
  android_compile_mips_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)

[peah-webrtc, 2016-05-08 09:47:32]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-05-08 09:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1943753002/#ps100001 (title:
"Added const specifier to local pointer")

[commit-bot: I haz the power, 2016-05-08 09:47:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943753002/100001

[commit-bot: I haz the power, 2016-05-08 10:47:20]

Description was changed from

==========
Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it 
more modifiable and modular.

The changes should be bitexact.


BUG=webrtc:5201, webrtc:5298
==========

to

==========
Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it 
more modifiable and modular.

The changes should be bitexact.


BUG=webrtc:5201, webrtc:5298
==========

[commit-bot: I haz the power, 2016-05-08 10:47:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-08 10:47:27]

Description was changed from

==========
Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it 
more modifiable and modular.

The changes should be bitexact.


BUG=webrtc:5201, webrtc:5298
==========

to

==========
Separated the functionalities in the OverdriveAndSuppress
method in the AEC into two methods.

This CL is step towards simplifying the AEC code, making it
more modifiable and modular.

The changes should be bitexact.

BUG=webrtc:5201, webrtc:5298

Committed: https://crrev.com/e69c37bc96f294e79eef4fea359ac8307d729a18
Cr-Commit-Position: refs/heads/master@{#12656}
==========

[commit-bot: I haz the power, 2016-05-08 10:47:28]

Patchset 6 (id:??) landed as
https://crrev.com/e69c37bc96f294e79eef4fea359ac8307d729a18
Cr-Commit-Position: refs/heads/master@{#12656}