Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1939723002: Removed the state as an input to OverdriveAndSuppress in the AEC. (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed the name of the variable overdriveSm and removed the state as an input to OverdriveAndSuppress in the AEC. This CL is step towards simplifying the AEC code, making it more modifiable and modular. The changes should be bitexact. BUG=webrtc:5201, webrtc:5298 Committed: https://crrev.com/7dd7ab5c51d760a0fc054d8d2057b54766f680a8 Cr-Commit-Position: refs/heads/master@{#12616}

Patch Set 1 : #

Patch Set 2 : Corrected an incorrect variable name causing build breakage on NEON #

Patch Set 3 : Rebase with latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
peah-webrtc
4 years, 7 months ago (2016-05-02 15:38:58 UTC) #4
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-05-03 07:38:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939723002/60001
4 years, 7 months ago (2016-05-03 15:00:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-03 17:01:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939723002/60001
4 years, 7 months ago (2016-05-03 18:26:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-03 20:26:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939723002/60001
4 years, 7 months ago (2016-05-03 20:27:41 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-03 21:08:16 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:08:24 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7dd7ab5c51d760a0fc054d8d2057b54766f680a8
Cr-Commit-Position: refs/heads/master@{#12616}

Powered by Google App Engine
This is Rietveld 408576698