Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1921493004: Revert of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (Closed)

Created:
4 years, 8 months ago by terelius
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (patchset #5 id:80001 of https://codereview.webrtc.org/1901973002/ ) Reason for revert: GetYPlane, GetYPitch etc is used by Chromium. Original issue's description: > Delete cricket::VideoFrame methods GetYPlane and GetYPitch. > > (And similarly for U and V). Also change video_frame_buffer method to > return a const ref to a scoped_ref_ptr. > > This cl is analogous to https://codereview.webrtc.org/1900673002/, > which delete corresponding methods in webrtc::VideoFrame. > > BUG=webrtc:5682 > > Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599 > Cr-Commit-Position: refs/heads/master@{#12492} TBR=magjed@webrtc.org,perkj@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/b05f994bb6f3055c852891c8acb531aee916a668 Cr-Commit-Position: refs/heads/master@{#12494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -220 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 1 chunk +9 lines, -18 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCI420Frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 2 chunks +14 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 7 chunks +23 lines, -35 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 19 chunks +84 lines, -126 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 4 chunks +47 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
terelius
Created Revert of Delete cricket::VideoFrame methods GetYPlane and GetYPitch.
4 years, 8 months ago (2016-04-25 18:41:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921493004/1
4 years, 8 months ago (2016-04-25 18:41:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 18:41:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b05f994bb6f3055c852891c8acb531aee916a668 Cr-Commit-Position: refs/heads/master@{#12494}
4 years, 8 months ago (2016-04-25 18:42:01 UTC) #5
nisse-webrtc
4 years, 7 months ago (2016-04-27 12:09:57 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1923903002/ by nisse@webrtc.org.

The reason for reverting is: Chrome has been updated, cl
https://codereview.chromium.org/1919283005/.

Powered by Google App Engine
This is Rietveld 408576698