Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: webrtc/media/base/videoframe.h

Issue 1921493004: Revert of Delete cricket::VideoFrame methods GetYPlane and GetYPitch. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videobroadcaster_unittest.cc ('k') | webrtc/media/base/videoframe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoframe.h
diff --git a/webrtc/media/base/videoframe.h b/webrtc/media/base/videoframe.h
index 4026c26b3b136ab26229ab884c249e4d38a15aba..9e0fbfd6d42ceff6f036935392b06dad54bee4d3 100644
--- a/webrtc/media/base/videoframe.h
+++ b/webrtc/media/base/videoframe.h
@@ -35,6 +35,18 @@
virtual size_t GetWidth() const final { return width(); }
virtual size_t GetHeight() const final { return height(); }
+ // These can return NULL if the object is not backed by a buffer.
+ virtual const uint8_t* GetYPlane() const = 0;
+ virtual const uint8_t* GetUPlane() const = 0;
+ virtual const uint8_t* GetVPlane() const = 0;
+ virtual uint8_t* GetYPlane() = 0;
+ virtual uint8_t* GetUPlane() = 0;
+ virtual uint8_t* GetVPlane() = 0;
+
+ virtual int32_t GetYPitch() const = 0;
+ virtual int32_t GetUPitch() const = 0;
+ virtual int32_t GetVPitch() const = 0;
+
// Returns the handle of the underlying video frame. This is used when the
// frame is backed by a texture. The object should be destroyed when it is no
// longer in use, so the underlying resource can be freed.
@@ -42,8 +54,8 @@
// Returns the underlying video frame buffer. This function is ok to call
// multiple times, but the returned object will refer to the same memory.
- virtual const rtc::scoped_refptr<webrtc::VideoFrameBuffer>&
- video_frame_buffer() const = 0;
+ virtual rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer()
+ const = 0;
// System monotonic clock, same timebase as rtc::TimeMicros().
virtual int64_t timestamp_us() const = 0;
« no previous file with comments | « webrtc/media/base/videobroadcaster_unittest.cc ('k') | webrtc/media/base/videoframe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698