Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682
Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}

[nisse-webrtc, 2016-04-19 08:54:31]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 08:54:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901973002/1

[commit-bot: I haz the power, 2016-04-19 08:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 08:56:37]

Dry run: Try jobs failed on following builders:
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/6781)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/9036)
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/10672)

[nisse-webrtc, 2016-04-19 10:03:38]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 10:03:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901973002/40001

[nisse-webrtc, 2016-04-19 10:54:54]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org, pbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org

[magjed_webrtc, 2016-04-19 11:50:52]

lgtm

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:59: return
const_frame->video_frame_buffer()->DataY();
This changes the behavior of this function, it used to return null if
video_frame_buffer() was null, now it will crash. Are you sure it will work?
Also, you don't need the const cast to above anymore, use
videoFrame->video_frame_buffer()->DataY() directly instead.

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/publ...
File talk/app/webrtc/objc/public/RTCI420Frame.h (right):

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/publ...
talk/app/webrtc/objc/public/RTCI420Frame.h:31: // TODO(nisse): It appears it
doesn't support any VideoFrame methods,
Can you do this directly in this CL if the change is not too big?

[commit-bot: I haz the power, 2016-04-19 12:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 12:04:23]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2016-04-19 14:33:57]

lgtm

[nisse-webrtc, 2016-04-20 07:21:53]

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/RTCI...
File talk/app/webrtc/objc/RTCI420Frame.mm (right):

https://codereview.webrtc.org/1901973002/diff/40001/talk/app/webrtc/objc/RTCI...
talk/app/webrtc/objc/RTCI420Frame.mm:59: return
const_frame->video_frame_buffer()->DataY();
On 2016/04/19 11:50:52, magjed_webrtc wrote:
> This changes the behavior of this function, it used to return null if
> video_frame_buffer() was null, now it will crash. Are you sure it will work?
> Also, you don't need the const cast to above anymore, use
> videoFrame->video_frame_buffer()->DataY() directly instead.

Don't really know, but webrtc/api/objc version, RTCVideoFrame, seems to tolerate
a NULL video frame buffer, so I'll do the same here.

[nisse-webrtc, 2016-04-25 14:18:29]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 14:18:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901973002/80001

[perkj_webrtc, 2016-04-25 14:24:10]

lgtm

https://codereview.webrtc.org/1901973002/diff/80001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe.h (right):

https://codereview.webrtc.org/1901973002/diff/80001/webrtc/media/base/videofr...
webrtc/media/base/videoframe.h:46: video_frame_buffer() const = 0;
git cl format?

[nisse-webrtc, 2016-04-25 14:27:13]

https://codereview.webrtc.org/1901973002/diff/80001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe.h (right):

https://codereview.webrtc.org/1901973002/diff/80001/webrtc/media/base/videofr...
webrtc/media/base/videoframe.h:46: video_frame_buffer() const = 0;
On 2016/04/25 14:24:09, perkj_webrtc wrote:
> git cl format?

git cl format likes it like that. I agree it looks strange.

[nisse-webrtc, 2016-04-25 14:27:18]

The CQ bit was unchecked by nisse@webrtc.org

[nisse-webrtc, 2016-04-25 14:27:18]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-04-25 14:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1901973002/#ps80001 (title:
"Fix type error in objc code.")

[commit-bot: I haz the power, 2016-04-25 14:27:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901973002/80001

[commit-bot: I haz the power, 2016-04-25 16:45:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-25 16:45:44]

Description was changed from

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682
==========

to

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682

Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}
==========

[commit-bot: I haz the power, 2016-04-25 16:45:45]

Patchset 5 (id:??) landed as
https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}

[terelius, 2016-04-25 18:41:32]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/1921493004/ by terelius@webrtc.org.

The reason for reverting is: GetYPlane, GetYPitch etc is used by Chromium..

[nisse-webrtc, 2016-04-27 06:58:51]

Description was changed from

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682

Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}
==========

to

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682

Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}
==========

[nisse-webrtc, 2016-04-27 06:59:37]

Reopened. Intend to update chrome, and then reland.

[pbos-webrtc, 2016-04-27 09:27:56]

On 2016/04/27 06:59:37, nisse-webrtc wrote:
> Reopened. Intend to update chrome, and then reland.

Closed. Please do a reland by reverting the revert instead.

[commit-bot: I haz the power, 2016-05-01 22:00:15]

Description was changed from

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682

Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}
==========

to

==========
Delete cricket::VideoFrame methods GetYPlane and GetYPitch.

(And similarly for U and V). Also change video_frame_buffer method to
return a const ref to a scoped_ref_ptr.

This cl is analogous to https://codereview.webrtc.org/1900673002/,
which delete corresponding methods in webrtc::VideoFrame.

BUG=webrtc:5682

Committed: https://crrev.com/1c27c6bf4cf0476dd2f09425509afaae4cdfe599
Cr-Commit-Position: refs/heads/master@{#12492}
==========