Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1914153002: Remove calls to ScopedToUnique and UniqueToScoped (Closed)

Created:
4 years, 8 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, hlundin-webrtc, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, mflodman, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@base-fix
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove calls to ScopedToUnique and UniqueToScoped They're just no-ops now, and will soon go away. BUG=webrtc:5520 Committed: https://crrev.com/1c7fdd86eb62813190de2d32e5923d42435929ba Cr-Commit-Position: refs/heads/master@{#12510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -55 lines) Patch
M webrtc/api/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/common_audio/lapped_transform.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/build_info.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/test/audio_device_test_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_device/test/func_test_manager.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/shared_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1917043005 Patch 1

Dependent Patchsets:

Issue 1921233002 Patch 40001

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 8 months ago (2016-04-26 12:34:23 UTC) #2
tommi
lgtm
4 years, 8 months ago (2016-04-26 14:20:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914153002/1
4 years, 8 months ago (2016-04-26 15:16:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 15:18:10 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:18:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1c7fdd86eb62813190de2d32e5923d42435929ba
Cr-Commit-Position: refs/heads/master@{#12510}

Powered by Google App Engine
This is Rietveld 408576698