Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1921233002: Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/ (Closed)

Created:
4 years, 8 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, mflodman, perkj_webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/ BUG=webrtc:5520 Committed: https://crrev.com/2c27a062ee46258abe9facc2cceee74f09bf6a99 Cr-Commit-Position: refs/heads/master@{#12511}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -155 lines) Patch
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tick_timer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_memory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/remote_ntp_time_estimator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/utility/include/jvm_android.h View 5 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/process_thread.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/jvm_android.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_processing/util/noise_estimation.h View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 8 months ago (2016-04-26 13:26:52 UTC) #4
tommi
Nice! I didn't review very closely, basically skimmed over the diff as I figure the ...
4 years, 8 months ago (2016-04-26 13:49:12 UTC) #5
kwiberg-webrtc
On 2016/04/26 13:49:12, tommi-webrtc wrote: > Nice! I didn't review very closely, basically skimmed over ...
4 years, 8 months ago (2016-04-26 13:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921233002/40001
4 years, 8 months ago (2016-04-26 15:35:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-26 15:37:58 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c27a062ee46258abe9facc2cceee74f09bf6a99 Cr-Commit-Position: refs/heads/master@{#12511}
4 years, 8 months ago (2016-04-26 15:38:11 UTC) #11
terelius
4 years, 8 months ago (2016-04-26 16:31:24 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.webrtc.org/1924443002/ by terelius@webrtc.org.

The reason for reverting is: Fails on Chromium FYI bots.

https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

Powered by Google App Engine
This is Rietveld 408576698