webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc - Issue 1914153002: Remove calls to ScopedToUnique and UniqueToScoped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

Issue 1914153002: Remove calls to ScopedToUnique and UniqueToScoped (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@base-fix

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc ('k') | webrtc/modules/utility/source/process_thread_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

index f3be09206ec455835eaf9d404c65c140f704e1fb..01115712622c6e528bece1235ebb45214b0c93cb 100644

--- a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

+++ b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc

@@ -207,8 +207,8 @@ TEST_F(TransportFeedbackAdapterTest, SendTimeWrapsBothWays) {

packets[i].sequence_number, packets[i].arrival_time_ms * 1000));

rtc::Buffer raw_packet = feedback->Build();

- feedback = rtc::ScopedToUnique(rtcp::TransportFeedback::ParseFrom(

- raw_packet.data(), raw_packet.size()));

+ feedback = rtcp::TransportFeedback::ParseFrom(raw_packet.data(),

+ raw_packet.size());

std::vector<PacketInfo> expected_packets;

expected_packets.push_back(packets[i]);

@@ -276,8 +276,8 @@ TEST_F(TransportFeedbackAdapterTest, TimestampDeltas) {

info.arrival_time_ms * 1000));

rtc::Buffer raw_packet = feedback->Build();

- feedback = rtc::ScopedToUnique(

- rtcp::TransportFeedback::ParseFrom(raw_packet.data(), raw_packet.size()));

+ feedback =

+ rtcp::TransportFeedback::ParseFrom(raw_packet.data(), raw_packet.size());

std::vector<PacketInfo> received_feedback;

@@ -297,8 +297,8 @@ TEST_F(TransportFeedbackAdapterTest, TimestampDeltas) {

EXPECT_TRUE(feedback->WithReceivedPacket(info.sequence_number,

info.arrival_time_ms * 1000));

raw_packet = feedback->Build();

- feedback = rtc::ScopedToUnique(

- rtcp::TransportFeedback::ParseFrom(raw_packet.data(), raw_packet.size()));

+ feedback =

+ rtcp::TransportFeedback::ParseFrom(raw_packet.data(), raw_packet.size());

EXPECT_TRUE(feedback.get() != nullptr);

EXPECT_CALL(*bitrate_estimator_, IncomingPacketFeedbackVector(_))