Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1917043005: #include "webrtc/base/constructormagic.h" where appropriate (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, interface-changes_webrtc.org, danilchap, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

#include "webrtc/base/constructormagic.h" where appropriate Any file that uses the RTC_DISALLOW_* macros should #include "webrtc/base/constructormagic.h", but a shocking number of them don't. This causes trouble when we try to wean files off of #including scoped_ptr.h, since a bunch of files get their constructormagic macros only from there. Rather than fixing these errors one by one as they turn up, this CL simply ensures that every file in the WebRTC tree that uses the RTC_DISALLOW_* macros #includes "webrtc/base/constructormagic.h". BUG=webrtc:5520 Committed: https://crrev.com/4485ffb58dbc6b446f624656ebb58907e71c884a Cr-Commit-Position: refs/heads/master@{#12509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -0 lines) Patch
M webrtc/api/audiotrack.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/dtmfsender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/jsepsessiondescription.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/mediacontroller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/remoteaudiosource.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/statstypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/asyncinvoker.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/asyncpacketsocket.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/asynctcpsocket.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/bufferqueue.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/fileutils.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/latebindingsymboltable.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/macasyncsocket.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/maccocoasocketserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/multipart.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/natserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/natsocketfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/opensslidentity.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/proxyserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/referencecountedsingletonfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/rollingaccumulator.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/scoped_autorelease_pool.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/scopedptrcollection_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/signalthread_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/socketadapters.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/socketstream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/sslidentity.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/swap_queue.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/task_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/testclient.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/testechoserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/thread_checker_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/virtualsocketserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/x11windowpicker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/ringbuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/libjingle/xmpp/pubsubstateclient.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpptask.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/rtpdump.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/videoadapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_decoder_opus.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/cropped_desktop_frame.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/differ.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/differ_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/desktop_configuration_monitor.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/window_capture_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_null.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/x11/shared_x_display.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/x11/x_server_pixel_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/remote_ntp_time_estimator.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/test/rtp_player.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/test/stream_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/asyncstuntcpsocket.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/rtp_file_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/call_stats.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/vie_receiver.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-04-26 12:33:46 UTC) #3
tommi
lgtm. thanks for fixing :)
4 years, 7 months ago (2016-04-26 14:20:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917043005/1
4 years, 7 months ago (2016-04-26 15:11:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 15:14:45 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 15:14:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4485ffb58dbc6b446f624656ebb58907e71c884a
Cr-Commit-Position: refs/heads/master@{#12509}

Powered by Google App Engine
This is Rietveld 408576698