Build dynamic iOS SDK.

Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=

Committed: https://crrev.com/9eeb6240c93efe2219d4d6f4cf706030e00f64d7
Cr-Commit-Position: refs/heads/master@{#12524}

[tkchin_webrtc, 2016-04-20 00:56:39]

Description was changed from

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=
==========

to

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=
==========

[tkchin_webrtc, 2016-04-20 00:56:40]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, kjellander@webrtc.org

[tkchin_webrtc, 2016-04-20 00:58:22]

This is a WIP - need to move the tests over as well, and fix mac build. But the
iOS bits should all be there. Was hoping to get preliminary comments, and help
with this presubmit error:

ou added one or more #includes that violate checkdeps rules.
  webrtc/api/objctests/RTCConfigurationTest.mm
      Illegal include: "webrtc/sdk/objc/Framework/Classes/NSString+StdString.h"
    Because of "-webrtc" from webrtc's include_rules. \
  webrtc/api/objctests/RTCConfigurationTest.mm
      Illegal include:
"webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h"
    Because of "-webrtc" from webrtc's include_rules. \

[tkchin_webrtc, 2016-04-20 01:01:34]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-04-20 01:11:39]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-04-20 01:21:14]

Patchset #1 (id:40001) has been deleted

[tkchin_webrtc, 2016-04-20 01:21:33]

Patchset #1 (id:60001) has been deleted

[tkchin_webrtc, 2016-04-20 01:30:37]

Patchset #1 (id:80001) has been deleted

[tkchin_webrtc, 2016-04-20 21:44:02]

Patchset #2 (id:120001) has been deleted

[tkchin_webrtc, 2016-04-20 21:44:17]

Patchset #1 (id:100001) has been deleted

[tkchin_webrtc, 2016-04-20 21:55:55]

Patchset #1 (id:140001) has been deleted

[tkchin_webrtc, 2016-04-20 22:04:26]

tkchin@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tkchin_webrtc, 2016-04-20 22:06:04]

PTAL
Updated -> fixed bot errors, presubmits and tests.

+tommi for new webrtc/sdk base directory approval

[tkchin_webrtc, 2016-04-20 22:06:37]

Patchset #1 (id:160001) has been deleted

[tkchin_webrtc, 2016-04-21 23:20:05]

On 2016/04/20 22:06:04, tkchin_webrtc wrote:
> PTAL
> Updated -> fixed bot errors, presubmits and tests.
> 
> +tommi for new webrtc/sdk base directory approval

Going to split this CL up to make it more review-able. Stay tuned.

[tkchin_webrtc, 2016-04-22 00:38:02]

On 2016/04/21 23:20:05, tkchin_webrtc wrote:
> On 2016/04/20 22:06:04, tkchin_webrtc wrote:
> > PTAL
> > Updated -> fixed bot errors, presubmits and tests.
> > 
> > +tommi for new webrtc/sdk base directory approval
> 
> Going to split this CL up to make it more review-able. Stay tuned.

Other than moving the OWNERS file (https://codereview.webrtc.org/1904343002/),
splitting the CL did not help much. Moving either of rtc_base_objc or
rtc_api_objc causes massive renames that touch many related files. It would be
easier to do it all in this CL.

@haysc can you look at the ObjC file changes?
@kjellander can you look at the gyp, PRESUBMIT and shell script changes?

[Chuck, 2016-04-22 16:20:12]

I'm assuming the .h files in the non headers dir were intentional, but I
commented on them anyway in case they weren't.

lgtm for the objc changes % the one alpha ordering comment

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/api/objctests/RTC...
File webrtc/api/objctests/RTCConfigurationTest.mm (left):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/api/objctests/RTC...
webrtc/api/objctests/RTCConfigurationTest.mm:2: *  Copyright 2015 The WebRTC
project authors. All Rights Reserved.
These test files are all marked M instead of D, is that expected?

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc
(right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:26:
#include "webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h"
Before webrtc/systems

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/NSString+StdString.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/NSString+StdString.h:1: /*
Should this be in headers?

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCOpenGLVideoRenderer.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCOpenGLVideoRenderer.h:11: #import
<Foundation/Foundation.h>
Should this file be in the headers dir?

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h:2: *  Copyright 2016 The
WebRTC Project Authors. All rights reserved.
Headers?

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.h:3: *
Should this be in headers?

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h:2: *  Copyright
2015 The WebRTC project authors. All Rights Reserved.
Headers?

[kjellander_webrtc, 2016-04-22 20:08:10]

whoa, nice work Zeke!

*.gyp*, PRESUBMIT, *.sh: lgtm with one question, which I believe you can just
fix.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk.gyp
File webrtc/sdk/sdk.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk.gyp#newco...
webrtc/sdk/sdk.gyp:271: }],  # OS=="ios"
nit: OS=="ios" or (OS=="mac" and mac_deployment_target=="10.7")

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk_tests.gyp
File webrtc/sdk/sdk_tests.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk_tests.gyp...
webrtc/sdk/sdk_tests.gyp:40: }],  # OS=="ios"
nit: OS=="ios" or (OS=="mac" and mac_deployment_target=="10.7")

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/webrtc.gyp
File webrtc/webrtc.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/webrtc.gyp#newcode38
webrtc/webrtc.gyp:38: ['OS=="ios" and build_with_chromium==0', {
What about if (OS=="mac" and mac_deployment_target=="10.7")
then the sdk will not be included. Shouldn't that be possible?

[tkchin_webrtc, 2016-04-26 21:26:24]

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/api/objctests/RTC...
File webrtc/api/objctests/RTCConfigurationTest.mm (left):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/api/objctests/RTC...
webrtc/api/objctests/RTCConfigurationTest.mm:2: *  Copyright 2015 The WebRTC
project authors. All Rights Reserved.
On 2016/04/22 16:20:11, Chuck wrote:
> These test files are all marked M instead of D, is that expected?

No, but I didn't do anything other than remove them from the directory. git log
--follow seems to do the right thing.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc
(right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:26:
#include "webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h"
On 2016/04/22 16:20:12, Chuck wrote:
> Before webrtc/systems

Done.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/NSString+StdString.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/NSString+StdString.h:1: /*
On 2016/04/22 16:20:12, Chuck wrote:
> Should this be in headers?

Nope. C++ related.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCOpenGLVideoRenderer.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCOpenGLVideoRenderer.h:11: #import
<Foundation/Foundation.h>
On 2016/04/22 16:20:12, Chuck wrote:
> Should this file be in the headers dir?

Would like to hide it for now and make users use the EAGLVideoView directly

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCUIApplication.h:2: *  Copyright 2016 The
WebRTC Project Authors. All rights reserved.
On 2016/04/22 16:20:12, Chuck wrote:
> Headers?

No, used to get UIApplication state from C++-land.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.h:3: *
On 2016/04/22 16:20:12, Chuck wrote:
> Should this be in headers?

No, class used to bridge C++ <-> ObjC

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h:2: *  Copyright
2015 The WebRTC project authors. All Rights Reserved.
On 2016/04/22 16:20:12, Chuck wrote:
> Headers?

No, C++ file.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk.gyp
File webrtc/sdk/sdk.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk.gyp#newco...
webrtc/sdk/sdk.gyp:271: }],  # OS=="ios"
On 2016/04/22 20:08:09, kjellander (webrtc) wrote:
> nit: OS=="ios" or (OS=="mac" and mac_deployment_target=="10.7")

Done.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk_tests.gyp
File webrtc/sdk/sdk_tests.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/sdk/sdk_tests.gyp...
webrtc/sdk/sdk_tests.gyp:40: }],  # OS=="ios"
On 2016/04/22 20:08:09, kjellander (webrtc) wrote:
> nit: OS=="ios" or (OS=="mac" and mac_deployment_target=="10.7")

Done.

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/webrtc.gyp
File webrtc/webrtc.gyp (right):

https://codereview.webrtc.org/1903663002/diff/180001/webrtc/webrtc.gyp#newcode38
webrtc/webrtc.gyp:38: ['OS=="ios" and build_with_chromium==0', {
On 2016/04/22 20:08:09, kjellander (webrtc) wrote:
> What about if (OS=="mac" and mac_deployment_target=="10.7")
> then the sdk will not be included. Shouldn't that be possible?

Done.

[tkchin_webrtc, 2016-04-27 00:59:59]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-04-27 01:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1903663002/#ps240001 (title:
"Fix test gyp")

[commit-bot: I haz the power, 2016-04-27 01:00:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903663002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903663002/240001

[commit-bot: I haz the power, 2016-04-27 01:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:07:30]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5098)

[tkchin_webrtc, 2016-04-27 01:09:43]

On 2016/04/27 01:00:07, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1903663002/240001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1903663002/240001

@tommi: Can I get a rubber stamp? Primarily for webrtc/DEPS, but also for
removing owners file from elsewhere.

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    talk/app/webrtc/legacy_objc_api.gyp
    webrtc/DEPS
    webrtc/base/objc/NSString+StdString.h
    webrtc/base/objc/NSString+StdString.mm
    webrtc/base/objc/OWNERS
    webrtc/base/objc/RTCCameraPreviewView.h
    webrtc/base/objc/RTCCameraPreviewView.m
    webrtc/base/objc/RTCDispatcher+Private.h
    webrtc/base/objc/RTCDispatcher.h
    webrtc/base/objc/RTCDispatcher.m
    webrtc/base/objc/RTCFieldTrials.h
    webrtc/base/objc/RTCFieldTrials.mm
    webrtc/base/objc/RTCFileLogger.h
    webrtc/base/objc/RTCFileLogger.mm
    webrtc/base/objc/RTCLogging.h
    webrtc/base/objc/RTCLogging.mm
    webrtc/base/objc/RTCMacros.h
    webrtc/base/objc/RTCSSLAdapter.h
    webrtc/base/objc/RTCSSLAdapter.mm
    webrtc/base/objc/RTCTracing.h
    webrtc/base/objc/RTCTracing.mm
    webrtc/base/objc/RTCUIApplication.h
    webrtc/base/objc/RTCUIApplication.mm

[tommi, 2016-04-27 08:48:56]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-04-27 08:48:57]

lgtm

[commit-bot: I haz the power, 2016-04-27 08:49:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903663002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903663002/240001

[commit-bot: I haz the power, 2016-04-27 08:54:25]

Description was changed from

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=
==========

to

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=
==========

[commit-bot: I haz the power, 2016-04-27 08:54:28]

Committed patchset #4 (id:240001)

[commit-bot: I haz the power, 2016-04-27 08:54:32]

Description was changed from

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=
==========

to

==========
Build dynamic iOS SDK.

- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.

BUG=

Committed: https://crrev.com/9eeb6240c93efe2219d4d6f4cf706030e00f64d7
Cr-Commit-Position: refs/heads/master@{#12524}
==========

[commit-bot: I haz the power, 2016-04-27 08:54:35]

Patchset 4 (id:??) landed as
https://crrev.com/9eeb6240c93efe2219d4d6f4cf706030e00f64d7
Cr-Commit-Position: refs/heads/master@{#12524}