Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: PRESUBMIT.py

Issue 1903663002: Build dynamic iOS SDK. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix test gyp Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/legacy_objc_api.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 return result 222 return result
223 223
224 def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api): 224 def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
225 pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'") 225 pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'")
226 violating_files = [] 226 violating_files = []
227 for f in gyp_files: 227 for f in gyp_files:
228 gyp_exceptions = ( 228 gyp_exceptions = (
229 'base_tests.gyp', 229 'base_tests.gyp',
230 'desktop_capture.gypi', 230 'desktop_capture.gypi',
231 'p2p.gyp', 231 'p2p.gyp',
232 'sdk.gyp',
232 'webrtc_test_common.gyp', 233 'webrtc_test_common.gyp',
233 'webrtc_tests.gypi', 234 'webrtc_tests.gypi',
234 ) 235 )
235 if f.LocalPath().endswith(gyp_exceptions): 236 if f.LocalPath().endswith(gyp_exceptions):
236 continue 237 continue
237 contents = input_api.ReadFile(f) 238 contents = input_api.ReadFile(f)
238 if pattern.search(contents): 239 if pattern.search(contents):
239 violating_files.append(f) 240 violating_files.append(f)
240 if violating_files: 241 if violating_files:
241 return [output_api.PresubmitError( 242 return [output_api.PresubmitError(
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 for builder in masters[master]: 515 for builder in masters[master]:
515 if 'presubmit' in builder: 516 if 'presubmit' in builder:
516 # Do not trigger presubmit builders, since they're likely to fail 517 # Do not trigger presubmit builders, since they're likely to fail
517 # (e.g. OWNERS checks before finished code review), and we're running 518 # (e.g. OWNERS checks before finished code review), and we're running
518 # local presubmit anyway. 519 # local presubmit anyway.
519 pass 520 pass
520 else: 521 else:
521 try_config[master][builder] = ['defaulttests'] 522 try_config[master][builder] = ['defaulttests']
522 523
523 return try_config 524 return try_config
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/legacy_objc_api.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698