Remove webrtc::ScopedVector

Remove webrtc::ScopedVector

We can (and should) use std::vector<std::unique_ptr<T>> instead.
Because it's standard, and because it's safer since callers have to
manually wrap elements in std::unique_ptr before inserting them and
manually unwrap them after inserting them.

Committed: https://crrev.com/4a206a96c121942c085cbbe1b1d73642508a6925
Cr-Commit-Position: refs/heads/master@{#12182}

[kwiberg-webrtc, 2016-03-28 00:26:21]

kwiberg@webrtc.org changed reviewers:
+ aluebs@webrtc.org, henrika@webrtc.org, pbos@webrtc.org

[kwiberg-webrtc, 2016-03-28 00:26:21]

henrika: OWNs webrtc/system_wrappers.
aluebs: OWNS webrtc/modules/audio_processing. Also seems to be the only one
besides ajm who's added uses of ScopedVector in modern times.
pbos: OWNs webrtc/test and webrtc/video.

[kwiberg-webrtc, 2016-03-28 00:30:43]

On 2016/03/28 00:26:21, kwiberg-webrtc wrote:
> henrika: OWNs webrtc/system_wrappers.
> aluebs: OWNS webrtc/modules/audio_processing. Also seems to be the only one
> besides ajm who's added uses of ScopedVector in modern times.
> pbos: OWNs webrtc/test and webrtc/video.

Also, I OWN common_audio, but of course I need a second pair of eyes for that
too. aluebs?

[kwiberg-webrtc, 2016-03-28 01:23:57]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-03-28 01:24:09]

Patchset #1 (id:20001) has been deleted

[aluebs-webrtc, 2016-03-28 23:08:30]

lgtm (including common_audio)

[pbos-webrtc, 2016-03-29 10:06:16]

lgtm for webrtc/test and webrtc/video

also lgtm for webrtc/system_wrappers even though I don't have OWNERS (I think)

[kwiberg-webrtc, 2016-03-29 19:38:40]

On 2016/03/29 10:06:16, pbos-webrtc wrote:
> lgtm for webrtc/test and webrtc/video
> 
> also lgtm for webrtc/system_wrappers even though I don't have OWNERS (I think)

Thanks. But no, you’re not an OWNER there, so I still need Henrik’s approval.
However, I’ll try switching to another Henrik, since the first one is apparently
unavailable at the moment.

[kwiberg-webrtc, 2016-03-29 19:44:09]

kwiberg@webrtc.org changed reviewers:
+ henrikg@webrtc.org, stefan@webrtc.org
- henrika@webrtc.org

[kwiberg-webrtc, 2016-03-29 19:44:10]

+henrikg for webrtc/system_wrappers
+stefan for webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

[Henrik Grunell WebRTC, 2016-03-31 09:19:13]

webrtc/system_wrappers lgtm

[stefan-webrtc, 2016-03-31 12:48:44]

lgtm rtp_rtcp

[kwiberg-webrtc, 2016-03-31 12:49:26]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-31 12:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839603002/40001

[commit-bot: I haz the power, 2016-03-31 14:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 14:49:58]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-03-31 16:32:45]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-31 16:32:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839603002/40001

[commit-bot: I haz the power, 2016-03-31 17:24:34]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-03-31 17:24:35]

Description was changed from

==========
Remove webrtc::ScopedVector

We can (and should) use std::vector<std::unique_ptr<T>> instead.
Because it's standard, and because it's safer since callers have to
manually wrap elements in std::unique_ptr before inserting them and
manually unwrap them after inserting them.
==========

to

==========
Remove webrtc::ScopedVector

We can (and should) use std::vector<std::unique_ptr<T>> instead.
Because it's standard, and because it's safer since callers have to
manually wrap elements in std::unique_ptr before inserting them and
manually unwrap them after inserting them.

Committed: https://crrev.com/4a206a96c121942c085cbbe1b1d73642508a6925
Cr-Commit-Position: refs/heads/master@{#12182}
==========

[commit-bot: I haz the power, 2016-03-31 17:24:37]

Patchset 1 (id:??) landed as
https://crrev.com/4a206a96c121942c085cbbe1b1d73642508a6925
Cr-Commit-Position: refs/heads/master@{#12182}