webrtc/common_audio/audio_ring_buffer.h - Issue 1839603002: Remove webrtc::ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/audio_ring_buffer.h

Issue 1839603002: Remove webrtc::ScopedVector (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_audio/audio_ring_buffer.h

diff --git a/webrtc/common_audio/audio_ring_buffer.h b/webrtc/common_audio/audio_ring_buffer.h

index e73f55b73b25da204d1db747c64b7fddcefdd7e1..ae825a3cd0bb62a491c826d01b5f6eb9976ed546 100644

--- a/webrtc/common_audio/audio_ring_buffer.h

+++ b/webrtc/common_audio/audio_ring_buffer.h

@@ -46,8 +46,7 @@ class AudioRingBuffer final {

void MoveReadPositionBackward(size_t frames);

private:

- // We don't use a ScopedVector because it doesn't support a specialized

- // deleter (like unique_ptr for instance.)

+ // TODO(kwiberg): Use std::vector<std::unique_ptr<RingBuffer>> instead.

std::vector<RingBuffer*> buffers_;

};