Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1834103002: Don't call operator== with scoped_ptr<T> and T* (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@using-4
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't call operator== with scoped_ptr<T> and T* That won't work when rtc::scoped_ptr becomes a type alias for std::unique_ptr. BUG=webrtc:5520 Committed: https://crrev.com/9708e9c5993b82624fbce4ca66033d6b3d2a4e63 Cr-Commit-Position: refs/heads/master@{#12145}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-27 23:56:51 UTC) #2
magjed_webrtc
lgtm
4 years, 8 months ago (2016-03-29 08:03:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834103002/40001
4 years, 8 months ago (2016-03-29 13:07:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-03-29 15:07:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834103002/40001
4 years, 8 months ago (2016-03-29 17:14:25 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 17:17:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:17:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9708e9c5993b82624fbce4ca66033d6b3d2a4e63
Cr-Commit-Position: refs/heads/master@{#12145}

Powered by Google App Engine
This is Rietveld 408576698