Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1808693002: Revert of VCMCodecTimer: Change filter from max to 95th percentile (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of VCMCodecTimer: Change filter from max to 95th percentile (patchset #5 id:180001 of https://codereview.webrtc.org/1742323002/ ) Reason for revert: Caused unexpected perf stats changes, see http://crbug/594575. Original issue's description: > VCMCodecTimer: Change filter from max to 95th percentile > > The purpose with this change is to make the filter more robust against anomalies. googMaxDecodeMs is expected to drop a litte by this. > > BUG=b/27306053 > > Committed: https://crrev.com/4bf0c717740d1834e810ea5f32b3c4306c64235f > Cr-Commit-Position: refs/heads/master@{#11952} TBR=stefan@webrtc.org,philipel@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594575 ,b/27306053 Committed: https://crrev.com/c4a74e95b545f4752d4e72961ac03c1380d4bc1f Cr-Commit-Position: refs/heads/master@{#12018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -307 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codec_timer.h View 1 chunk +25 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/codec_timer.cc View 1 chunk +71 lines, -31 lines 0 comments Download
D webrtc/modules/video_coding/percentile_filter.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/modules/video_coding/percentile_filter.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/modules/video_coding/percentile_filter_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M webrtc/modules/video_coding/timing.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/timing.cc View 10 chunks +19 lines, -21 lines 0 comments Download
M webrtc/modules/video_coding/timing_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
magjed_webrtc
Created Revert of VCMCodecTimer: Change filter from max to 95th percentile
4 years, 9 months ago (2016-03-16 12:38:06 UTC) #1
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-16 12:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808693002/1
4 years, 9 months ago (2016-03-16 13:03:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 14:51:48 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4a74e95b545f4752d4e72961ac03c1380d4bc1f Cr-Commit-Position: refs/heads/master@{#12018}
4 years, 9 months ago (2016-03-16 14:51:56 UTC) #9
magjed_webrtc
4 years, 9 months ago (2016-03-22 09:39:43 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1824763003/ by magjed@webrtc.org.

The reason for reverting is: This CL did not cause the unexpected perf changes..

Powered by Google App Engine
This is Rietveld 408576698