Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: webrtc/modules/video_coding/codec_timer.h

Issue 1808693002: Revert of VCMCodecTimer: Change filter from max to 95th percentile (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/codec_timer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_ 11 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
12 #define WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_ 12 #define WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
13 13
14 #include <queue>
15
16 #include "webrtc/modules/include/module_common_types.h" 14 #include "webrtc/modules/include/module_common_types.h"
17 #include "webrtc/modules/video_coding/percentile_filter.h"
18 #include "webrtc/typedefs.h" 15 #include "webrtc/typedefs.h"
19 16
20 namespace webrtc { 17 namespace webrtc {
21 18
19 // MAX_HISTORY_SIZE * SHORT_FILTER_MS defines the window size in milliseconds
20 #define MAX_HISTORY_SIZE 10
21 #define SHORT_FILTER_MS 1000
22
23 class VCMShortMaxSample {
24 public:
25 VCMShortMaxSample() : shortMax(0), timeMs(-1) {}
26
27 int32_t shortMax;
28 int64_t timeMs;
29 };
30
22 class VCMCodecTimer { 31 class VCMCodecTimer {
23 public: 32 public:
24 VCMCodecTimer(); 33 VCMCodecTimer();
25 34
26 // Add a new decode time to the filter. 35 // Updates the max filtered decode time.
27 void AddTiming(int64_t new_decode_time_ms, int64_t now_ms); 36 void MaxFilter(int32_t newDecodeTimeMs, int64_t nowMs);
28 37
29 // Get the required decode time in ms. It is the 95th percentile observed 38 // Empty the list of timers.
30 // decode time within a time window. 39 void Reset();
31 int64_t RequiredDecodeTimeMs() const; 40
41 // Get the required decode time in ms.
42 int32_t RequiredDecodeTimeMs(FrameType frameType) const;
32 43
33 private: 44 private:
34 struct Sample { 45 void UpdateMaxHistory(int32_t decodeTime, int64_t now);
35 Sample(int64_t decode_time_ms, int64_t sample_time_ms); 46 void ProcessHistory(int64_t nowMs);
36 int64_t decode_time_ms;
37 int64_t sample_time_ms;
38 };
39 47
48 int32_t _filteredMax;
40 // The number of samples ignored so far. 49 // The number of samples ignored so far.
41 int ignored_sample_count_; 50 int32_t _ignoredSampleCount;
42 // Queue with history of latest decode time values. 51 int32_t _shortMax;
43 std::queue<Sample> history_; 52 VCMShortMaxSample _history[MAX_HISTORY_SIZE];
44 // |filter_| contains the same values as |history_|, but in a data structure
45 // that allows efficient retrieval of the percentile value.
46 PercentileFilter filter_;
47 }; 53 };
48 54
49 } // namespace webrtc 55 } // namespace webrtc
50 56
51 #endif // WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_ 57 #endif // WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/codec_timer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698