Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1526463002: Made EglBase an abstract class and cleaned up. (Closed)

Created:
5 years ago by perkj_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Made EglBase an abstract class and cleaned up. Adds EglBase10 that implemenents EglBase for EGL 1.0 BUG=webrtc:4993 TBR=glaznev@webrtc.org Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e Cr-Commit-Position: refs/heads/master@{#11011}

Patch Set 1 #

Patch Set 2 : Added the file... #

Patch Set 3 : Fix gyp file #

Patch Set 4 : Fixed build. #

Messages

Total messages: 15 (8 generated)
perkj_webrtc
please?
5 years ago (2015-12-14 08:08:38 UTC) #3
magjed_webrtc
lgtm
5 years ago (2015-12-14 09:42:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526463002/60001
5 years ago (2015-12-14 14:19:58 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-14 14:21:17 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e Cr-Commit-Position: refs/heads/master@{#11011}
5 years ago (2015-12-14 14:21:24 UTC) #11
perkj_webrtc
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.webrtc.org/1522073002/ by perkj@webrtc.org. ...
5 years ago (2015-12-14 14:43:08 UTC) #12
kjellander_webrtc
5 years ago (2015-12-14 15:31:04 UTC) #14
Message was sent while issue was closed.
Adding glaznev@ correctly spelled.

Powered by Google App Engine
This is Rietveld 408576698