Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1522073002: Revert of Made EglBase an abstract class and cleaned up. (Closed)

Created:
5 years ago by perkj_webrtc
Modified:
5 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Made EglBase an abstract class and cleaned up. (patchset #4 id:60001 of https://codereview.webrtc.org/1526463002/ ) Reason for revert: Revert due breaking other clients. Original issue's description: > Made EglBase an abstract class and cleaned up. > Adds EglBase10 that implemenents EglBase for EGL 1.0 > > BUG=webrtc:4993 > TBR=glaznew@webrtc.org > > Committed: https://crrev.com/3207916f35ded33f586774e2c98d4d0089fe3c6e > Cr-Commit-Position: refs/heads/master@{#11011} TBR=magjed@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4993 Committed: https://crrev.com/e22e1cb399748112f308b488e7535754ef6b807d Cr-Commit-Position: refs/heads/master@{#11013}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
perkj_webrtc
Created Revert of Made EglBase an abstract class and cleaned up.
5 years ago (2015-12-14 14:43:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522073002/1
5 years ago (2015-12-14 14:43:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 14:43:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e22e1cb399748112f308b488e7535754ef6b807d Cr-Commit-Position: refs/heads/master@{#11013}
5 years ago (2015-12-14 14:43:46 UTC) #5
perkj_webrtc
5 years ago (2015-12-15 10:47:51 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1522303004/ by perkj@webrtc.org.

The reason for reverting is: Clients have been updated..

Powered by Google App Engine
This is Rietveld 408576698