Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1524703006: WinSDK samples: Workaround warnings for Clang on Windows. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
tommi, henrika_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/winsdk_samples_v71@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

WinSDK samples: Workaround warnings for Clang on Windows. BUG=webrtc:5360 R=henrika@webrtc.org, tommi@webrtc.org Committed: e71b549167a665d7424d6f1dadfbff4b4aad1589

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Samples/multimedia/directshow/baseclasses/wxdebug.cpp View 1 chunk +1 line, -1 line 2 comments Download
M Samples/multimedia/directshow/baseclasses/wxutil.cpp View 1 chunk +1 line, -1 line 0 comments Download
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_webrtc
This is all that was needed. Loop in tommi@ if you feel it's necessary.
5 years ago (2015-12-15 15:25:08 UTC) #2
henrika_webrtc
Do you mind running this via tommi@ as well, please. LGTM
5 years ago (2015-12-15 15:31:23 UTC) #3
kjellander_webrtc
+tommi
5 years ago (2015-12-15 15:37:26 UTC) #5
tommi
lgtm % wondering about the cast https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow/baseclasses/wxdebug.cpp File Samples/multimedia/directshow/baseclasses/wxdebug.cpp (right): https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow/baseclasses/wxdebug.cpp#newcode1237 Samples/multimedia/directshow/baseclasses/wxdebug.cpp:1237: CDisp::CDisp(static_cast<IPin*>(pp)); hmm.. pp ...
5 years ago (2015-12-15 16:39:47 UTC) #6
kjellander_webrtc
https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow/baseclasses/wxdebug.cpp File Samples/multimedia/directshow/baseclasses/wxdebug.cpp (right): https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow/baseclasses/wxdebug.cpp#newcode1237 Samples/multimedia/directshow/baseclasses/wxdebug.cpp:1237: CDisp::CDisp(static_cast<IPin*>(pp)); On 2015/12/15 16:39:47, tommi (webrtc) wrote: > hmm.. ...
5 years ago (2015-12-15 17:57:55 UTC) #7
kjellander_webrtc
Committed patchset #1 (id:1) manually as 4a4ee817eb41e51bcafc95e295bf287526330ff0 (presubmit successful).
5 years ago (2015-12-15 18:02:24 UTC) #9
kjellander_webrtc
Committed patchset #1 (id:1) manually as e71b549167a665d7424d6f1dadfbff4b4aad1589 (presubmit successful).
5 years ago (2015-12-16 07:24:36 UTC) #12
kjellander_webrtc
5 years ago (2015-12-16 07:27:25 UTC) #13
Message was sent while issue was closed.
On 2015/12/16 07:24:36, kjellander (webrtc) wrote:
> Committed patchset #1 (id:1) manually as
> e71b549167a665d7424d6f1dadfbff4b4aad1589 (presubmit successful).

Previous commit didn't go through due to git-svn config. I remove it and
re-created my .gitcookies and then I was able to land properly with 'git cl
land'.

Powered by Google App Engine
This is Rietveld 408576698