Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: Samples/multimedia/directshow/baseclasses/wxdebug.cpp

Issue 1524703006: WinSDK samples: Workaround warnings for Clang on Windows. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc/deps/third_party/winsdk_samples_v71@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Samples/multimedia/directshow/baseclasses/wxutil.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //------------------------------------------------------------------------------ 1 //------------------------------------------------------------------------------
2 // File: WXDebug.cpp 2 // File: WXDebug.cpp
3 // 3 //
4 // Desc: DirectShow base classes - implements ActiveX system debugging 4 // Desc: DirectShow base classes - implements ActiveX system debugging
5 // facilities. 5 // facilities.
6 // 6 //
7 // Copyright (c) 1992-2001 Microsoft Corporation. All rights reserved. 7 // Copyright (c) 1992-2001 Microsoft Corporation. All rights reserved.
8 //------------------------------------------------------------------------------ 8 //------------------------------------------------------------------------------
9 9
10 10
(...skipping 1216 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 1227
1228 pf->Release(); 1228 pf->Release();
1229 1229
1230 return; 1230 return;
1231 } 1231 }
1232 1232
1233 IPin *pp; 1233 IPin *pp;
1234 hr = pUnk->QueryInterface(IID_IPin, (void **)&pp); 1234 hr = pUnk->QueryInterface(IID_IPin, (void **)&pp);
1235 if(SUCCEEDED(hr)) 1235 if(SUCCEEDED(hr))
1236 { 1236 {
1237 CDisp::CDisp(pp); 1237 CDisp::CDisp(static_cast<IPin*>(pp));
tommi 2015/12/15 16:39:47 hmm.. pp is already IPin*. Why is this cast neede
kjellander_webrtc 2015/12/15 17:57:55 henrika@ and I were wondering that too. The compil
1238 pp->Release(); 1238 pp->Release();
1239 return; 1239 return;
1240 } 1240 }
1241 } 1241 }
1242 1242
1243 1243
1244 CDisp::~CDisp() 1244 CDisp::~CDisp()
1245 { 1245 {
1246 } 1246 }
1247 1247
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 1465
1466 pFilter->Release(); 1466 pFilter->Release();
1467 } 1467 }
1468 1468
1469 pFilters->Release(); 1469 pFilters->Release();
1470 1470
1471 } 1471 }
1472 1472
1473 #endif 1473 #endif
1474 1474
OLDNEW
« no previous file with comments | « no previous file | Samples/multimedia/directshow/baseclasses/wxutil.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698