Samples/multimedia/directshow/baseclasses/wxutil.cpp - Issue 1524703006: WinSDK samples: Workaround warnings for Clang on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Samples/multimedia/directshow/baseclasses/wxutil.cpp

Issue 1524703006: WinSDK samples: Workaround warnings for Clang on Windows. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc/deps/third_party/winsdk_samples_v71@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Samples/multimedia/directshow/baseclasses/wxutil.cpp

diff --git a/Samples/multimedia/directshow/baseclasses/wxutil.cpp b/Samples/multimedia/directshow/baseclasses/wxutil.cpp

index 5bc97a9ae44ce4be4d34b84c8bac93f0e66d5203..a79153b170e85fdf1df189d3fd5add2165822de7 100644

--- a/Samples/multimedia/directshow/baseclasses/wxutil.cpp

+++ b/Samples/multimedia/directshow/baseclasses/wxutil.cpp

@@ -381,7 +381,7 @@ void * __stdcall memmoveInternal(void * dst, const void * src, size_t count)

{

void * ret = dst;

-#ifdef _X86_

+#if defined(_X86_) && !defined(__clang__)

if (dst <= src || (char *)dst >= ((char *)src + count)) {

« Samples/multimedia/directshow/baseclasses/wxdebug.cpp ('K') | « Samples/multimedia/directshow/baseclasses/wxdebug.cpp ('k') | codereview.settings » ('j') | no next file with comments »