WinSDK samples: Workaround warnings for Clang on Windows.

WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org

Committed: e71b549167a665d7424d6f1dadfbff4b4aad1589

[kjellander_webrtc, 2015-12-15 15:25:08]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2015-12-15 15:25:08]

This is all that was needed. Loop in tommi@ if you feel it's necessary.

[henrika_webrtc, 2015-12-15 15:31:23]

Do you mind running this via tommi@ as well, please.

LGTM

[kjellander_webrtc, 2015-12-15 15:37:26]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2015-12-15 15:37:26]

+tommi

[tommi, 2015-12-15 16:39:47]

lgtm % wondering about the cast

https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow...
File Samples/multimedia/directshow/baseclasses/wxdebug.cpp (right):

https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow...
Samples/multimedia/directshow/baseclasses/wxdebug.cpp:1237:
CDisp::CDisp(static_cast<IPin*>(pp));
hmm.. pp is already IPin*.  Why is this cast needed?

[kjellander_webrtc, 2015-12-15 17:57:55]

https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow...
File Samples/multimedia/directshow/baseclasses/wxdebug.cpp (right):

https://codereview.webrtc.org/1524703006/diff/1/Samples/multimedia/directshow...
Samples/multimedia/directshow/baseclasses/wxdebug.cpp:1237:
CDisp::CDisp(static_cast<IPin*>(pp));
On 2015/12/15 16:39:47, tommi (webrtc) wrote:
> hmm.. pp is already IPin*.  Why is this cast needed?

henrika@ and I were wondering that too. The compiler couldn't match any of the
available CDisp constructors without the cast. 
It kept complaining about that this line was trying to call a constructor with
no arguments.

[kjellander_webrtc, 2015-12-15 18:02:23]

Description was changed from

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
==========

to

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org

Committed: 4a4ee817eb41e51bcafc95e295bf287526330ff0
==========

[kjellander_webrtc, 2015-12-15 18:02:24]

Committed patchset #1 (id:1) manually as
4a4ee817eb41e51bcafc95e295bf287526330ff0 (presubmit successful).

[kjellander_webrtc, 2015-12-16 07:05:07]

Description was changed from

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org

Committed: 4a4ee817eb41e51bcafc95e295bf287526330ff0
==========

to

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org
==========

[kjellander_webrtc, 2015-12-16 07:24:35]

Description was changed from

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org
==========

to

==========
WinSDK samples: Workaround warnings for Clang on Windows.

BUG=webrtc:5360
R=henrika@webrtc.org, tommi@webrtc.org

Committed: e71b549167a665d7424d6f1dadfbff4b4aad1589
==========

[kjellander_webrtc, 2015-12-16 07:24:36]

Committed patchset #1 (id:1) manually as
e71b549167a665d7424d6f1dadfbff4b4aad1589 (presubmit successful).

[kjellander_webrtc, 2015-12-16 07:27:25]

On 2015/12/16 07:24:36, kjellander (webrtc) wrote:
> Committed patchset #1 (id:1) manually as
> e71b549167a665d7424d6f1dadfbff4b4aad1589 (presubmit successful).

Previous commit didn't go through due to git-svn config. I remove it and
re-created my .gitcookies and then I was able to land properly with 'git cl
land'.