Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1522223002: Disable warnings failing when using Clang on Windows (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable warnings failing when using Clang on Windows. This makes it possible to build WebRTC using Clang on Windows. Depends on https://codereview.webrtc.org/1524703006/ BUG=webrtc:5360, webrtc:5366 NOTRY=True Committed: https://crrev.com/7cae30cbe1200854bbe26205ab53d0f418c8d443 Cr-Commit-Position: refs/heads/master@{#11058}

Patch Set 1 : #

Patch Set 2 : Rolled winsdk_samples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -4 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/libjingle_tests.gyp View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/winsdk_samples/winsdk_samples.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac_test.gypi View 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device.gypi View 2 chunks +23 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/modules/video_render/video_render.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kjellander_webrtc
I filed http://code.google.com/p/webrtc/issues/detail?id=5366 for fixing the actual warnings.
5 years ago (2015-12-16 08:05:27 UTC) #8
kjellander_webrtc
Niklas can you take a look instead? I think there are some locations that are ...
5 years ago (2015-12-16 18:50:38 UTC) #10
niklas.enbom
lgtm, just to make it clear: this is for code that is not used in ...
5 years ago (2015-12-16 19:15:44 UTC) #11
kjellander_webrtc
On 2015/12/16 19:15:44, niklas.enbom wrote: > lgtm, just to make it clear: this is for ...
5 years ago (2015-12-16 19:30:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522223002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522223002/100001
5 years ago (2015-12-16 22:04:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years ago (2015-12-16 22:05:33 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-16 22:05:41 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cae30cbe1200854bbe26205ab53d0f418c8d443
Cr-Commit-Position: refs/heads/master@{#11058}

Powered by Google App Engine
This is Rietveld 408576698