Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: webrtc/modules/audio_device/audio_device.gypi

Issue 1522223002: Disable warnings failing when using Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rolled winsdk_samples Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_device/audio_device.gypi
diff --git a/webrtc/modules/audio_device/audio_device.gypi b/webrtc/modules/audio_device/audio_device.gypi
index 480276836b7092a8a0a5276eeb93c681b2898369..41456a80aefc433ce1ce30fa51f1ec87642e35cc 100644
--- a/webrtc/modules/audio_device/audio_device.gypi
+++ b/webrtc/modules/audio_device/audio_device.gypi
@@ -194,6 +194,27 @@
],
},
}],
+ ['OS=="win" and clang==1', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ '-Wno-bool-conversion',
+ '-Wno-delete-non-virtual-dtor',
+ '-Wno-logical-op-parentheses',
+ '-Wno-microsoft-extra-qualification',
+ '-Wno-microsoft-goto',
+ '-Wno-missing-braces',
+ '-Wno-parentheses-equality',
+ '-Wno-reorder',
+ '-Wno-shift-overflow',
+ '-Wno-tautological-compare',
+ '-Wno-unused-private-field',
+ ],
+ },
+ },
+ }],
], # conditions
}], # include_internal_audio_device==1
], # conditions
@@ -205,8 +226,8 @@
'targets': [
{
'target_name': 'audio_device_tests',
- 'type': 'executable',
- 'dependencies': [
+ 'type': 'executable',
+ 'dependencies': [
'audio_device',
'webrtc_utility',
'<(webrtc_root)/test/test.gyp:test_support_main',
« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/isac_test.gypi ('k') | webrtc/modules/video_capture/video_capture.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698