Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/winsdk_samples/winsdk_samples.gyp

Issue 1522223002: Disable warnings failing when using Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rolled winsdk_samples Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/libjingle_tests.gyp ('k') | webrtc/base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/winsdk_samples/winsdk_samples.gyp
diff --git a/third_party/winsdk_samples/winsdk_samples.gyp b/third_party/winsdk_samples/winsdk_samples.gyp
index a9b8598adf8d757a9a9acfdd79d5532869807cbf..12bc265ec7b894dcf3391f2c4e86bd5e281b2179 100644
--- a/third_party/winsdk_samples/winsdk_samples.gyp
+++ b/third_party/winsdk_samples/winsdk_samples.gyp
@@ -85,6 +85,32 @@
'<(baseclasses_dir)/wxutil.cpp',
'<(baseclasses_dir)/wxutil.h',
],
+ 'conditions': [
+ ['clang==1', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ '-Wno-comment',
+ '-Wno-delete-non-virtual-dtor',
+ '-Wno-ignored-attributes',
+ '-Wno-logical-op-parentheses',
+ '-Wno-non-pod-varargs',
+ '-Wno-microsoft-extra-qualification',
+ '-Wno-missing-braces',
+ '-Wno-overloaded-virtual',
+ '-Wno-parentheses',
+ '-Wno-reorder',
+ '-Wno-string-conversion',
+ '-Wno-tautological-constant-out-of-range-compare',
+ '-Wno-unused-private-field',
+ '-Wno-writable-strings',
+ ],
+ },
+ },
+ },],
+ ], # conditions.
},
],
}
« no previous file with comments | « talk/libjingle_tests.gyp ('k') | webrtc/base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698