Add webrtc/base to deprecated APIs.

Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True

Committed: https://crrev.com/fd595235878df06e7737ba8b72e8792d31d58d8a
Cr-Commit-Position: refs/heads/master@{#10892}

[kjellander_webrtc, 2015-12-03 13:38:15]

kjellander@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, tommi@webrtc.org

[kwiberg-webrtc, 2015-12-03 13:44:27]

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: 'webrtc/base',  # DEPRECATED (will go away).
What does DEPRECATED mean? That webrtc/base is going away? That external users
shouldn't include stuff from there directly? Indirectly?

[phoglund, 2015-12-03 13:58:54]

phoglund@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[phoglund, 2015-12-03 13:58:55]

lgtm

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: 'webrtc/base',  # DEPRECATED (will go away).
On 2015/12/03 13:44:27, kwiberg-webrtc wrote:
> What does DEPRECATED mean? That webrtc/base is going away? That external users
> shouldn't include stuff from there directly? Indirectly?

I guess what we want to say here is "don't depend on this thing directly."

[kjellander_webrtc, 2015-12-03 14:03:53]

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: 'webrtc/base',  # DEPRECATED (will go away).
On 2015/12/03 13:58:55, phoglund wrote:
> On 2015/12/03 13:44:27, kwiberg-webrtc wrote:
> > What does DEPRECATED mean? That webrtc/base is going away? That external
users
> > shouldn't include stuff from there directly? Indirectly?

I guess it could be phrased differently, but I mean going away from this list of
"supported" APIs, since we don't want to support it (but haven't been able to
update downstream code yet).
If they use another API that includes files from webrtc/base indirectly, that's
not their problem (just ours).

> I guess what we want to say here is "don't depend on this thing directly."
Yes.

[kwiberg-webrtc, 2015-12-03 14:52:28]

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: 'webrtc/base',  # DEPRECATED (will go away).
On 2015/12/03 14:03:53, kjellander (webrtc) wrote:
> On 2015/12/03 13:58:55, phoglund wrote:
> > On 2015/12/03 13:44:27, kwiberg-webrtc wrote:
> > > What does DEPRECATED mean? That webrtc/base is going away? That external
> users
> > > shouldn't include stuff from there directly? Indirectly?
> 
> I guess it could be phrased differently, but I mean going away from this list
of
> "supported" APIs, since we don't want to support it (but haven't been able to
> update downstream code yet).
> If they use another API that includes files from webrtc/base indirectly,
that's
> not their problem (just ours).
> 
> > I guess what we want to say here is "don't depend on this thing directly."
> Yes.

OK, sounds good. Perhaps a comment on line 24 that explains that this is the
list of directories where we don't change headers willy-nilly, and that
DEPRECATED means that the entry in question is going away from the list?

[kjellander_webrtc, 2015-12-03 15:12:34]

PTAL

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1497733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: 'webrtc/base',  # DEPRECATED (will go away).
On 2015/12/03 14:52:28, kwiberg-webrtc wrote:
> On 2015/12/03 14:03:53, kjellander (webrtc) wrote:
> > On 2015/12/03 13:58:55, phoglund wrote:
> > > On 2015/12/03 13:44:27, kwiberg-webrtc wrote:
> > > > What does DEPRECATED mean? That webrtc/base is going away? That external
> > users
> > > > shouldn't include stuff from there directly? Indirectly?
> > 
> > I guess it could be phrased differently, but I mean going away from this
list
> of
> > "supported" APIs, since we don't want to support it (but haven't been able
to
> > update downstream code yet).
> > If they use another API that includes files from webrtc/base indirectly,
> that's
> > not their problem (just ours).
> > 
> > > I guess what we want to say here is "don't depend on this thing directly."
> > Yes.
> 
> OK, sounds good. Perhaps a comment on line 24 that explains that this is the
> list of directories where we don't change headers willy-nilly, and that
> DEPRECATED means that the entry in question is going away from the list?

You're right. I added a descriptive comment now and removed the confusing "will
go away" text.

[kwiberg-webrtc, 2015-12-03 19:22:19]

Looks excellent! lgtm

[kjellander_webrtc, 2015-12-04 08:23:03]

Description was changed from

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
==========

to

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True
==========

[kjellander_webrtc, 2015-12-04 08:23:07]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2015-12-04 08:23:07]

The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1497733002/#ps20001 (title:
"Added descriptive comment about the native APIs")

[commit-bot: I haz the power, 2015-12-04 08:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497733002/20001

[tandrii(chromium), 2015-12-04 09:53:19]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2015-12-04 09:53:19]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-12-04 09:53:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497733002/20001

[tandrii(chromium), 2015-12-04 09:53:46]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2015-12-04 09:53:48]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-12-04 09:54:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497733002/20001

[tandrii(chromium), 2015-12-04 09:57:55]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2015-12-04 10:01:11]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-12-04 10:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497733002/20001

[commit-bot: I haz the power, 2015-12-04 10:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 10:23:29]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tandrii(chromium), 2015-12-04 10:26:14]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-12-04 10:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497733002/20001

[commit-bot: I haz the power, 2015-12-04 10:44:11]

Description was changed from

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True
==========

to

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True
==========

[commit-bot: I haz the power, 2015-12-04 10:44:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-04 10:44:20]

Description was changed from

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True
==========

to

==========
Add webrtc/base to deprecated APIs.

webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.

BUG=webrtc:5095
NOTRY=True

Committed: https://crrev.com/fd595235878df06e7737ba8b72e8792d31d58d8a
Cr-Commit-Position: refs/heads/master@{#10892}
==========

[commit-bot: I haz the power, 2015-12-04 10:44:21]

Patchset 2 (id:??) landed as
https://crrev.com/fd595235878df06e7737ba8b72e8792d31d58d8a
Cr-Commit-Position: refs/heads/master@{#10892}