Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: PRESUBMIT.py

Issue 1497733002: Add webrtc/base to deprecated APIs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added descriptive comment about the native APIs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index fe9d0104a908878dc7dbcab59bf0e7e7405a269d..3ceb67016a293556a551b7c00f4038673c8c5159 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -21,26 +21,36 @@ CPPLINT_DIRS = [
'webrtc/video_engine',
]
+# List of directories of "supported" native APIs. That means changes to headers
+# will be done in a compatible way following this scheme:
+# 1. Non-breaking changes are made.
+# 2. The old APIs as marked as deprecated (with comments).
+# 3. Deprecation is announced to discuss-webrtc@googlegroups.com and
+# webrtc-users@google.com (internal list).
+# 4. (later) The deprecated APIs are removed.
+# Directories marked as DEPRECATED should not be used. They're only present in
+# the list to support legacy downstream code.
NATIVE_API_DIRS = (
'talk/app/webrtc',
'webrtc',
- 'webrtc/common_audio/include', # DEPRECATED (will go away).
+ 'webrtc/base', # DEPRECATED.
+ 'webrtc/common_audio/include', # DEPRECATED.
'webrtc/modules/audio_coding/include',
- 'webrtc/modules/audio_conference_mixer/include', # DEPRECATED (will go away).
+ 'webrtc/modules/audio_conference_mixer/include', # DEPRECATED.
'webrtc/modules/audio_device/include',
'webrtc/modules/audio_processing/include',
'webrtc/modules/bitrate_controller/include',
'webrtc/modules/include',
'webrtc/modules/remote_bitrate_estimator/include',
'webrtc/modules/rtp_rtcp/include',
- 'webrtc/modules/rtp_rtcp/source', # DEPRECATED (will go away).
+ 'webrtc/modules/rtp_rtcp/source', # DEPRECATED.
'webrtc/modules/utility/include',
'webrtc/modules/video_coding/codecs/h264/include',
'webrtc/modules/video_coding/codecs/i420/include',
'webrtc/modules/video_coding/codecs/vp8/include',
'webrtc/modules/video_coding/codecs/vp9/include',
'webrtc/modules/video_coding/include',
- 'webrtc/system_wrappers/include', # DEPRECATED (will go away).
+ 'webrtc/system_wrappers/include', # DEPRECATED.
'webrtc/voice_engine/include',
)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698