Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: PRESUBMIT.py

Issue 1497733002: Add webrtc/base to deprecated APIs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added descriptive comment about the native APIs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
11 import platform 11 import platform
12 import re 12 import re
13 import subprocess 13 import subprocess
14 import sys 14 import sys
15 15
16 16
17 # Directories that will be scanned by cpplint by the presubmit script. 17 # Directories that will be scanned by cpplint by the presubmit script.
18 CPPLINT_DIRS = [ 18 CPPLINT_DIRS = [
19 'webrtc/audio', 19 'webrtc/audio',
20 'webrtc/call', 20 'webrtc/call',
21 'webrtc/video_engine', 21 'webrtc/video_engine',
22 ] 22 ]
23 23
24 # List of directories of "supported" native APIs. That means changes to headers
25 # will be done in a compatible way following this scheme:
26 # 1. Non-breaking changes are made.
27 # 2. The old APIs as marked as deprecated (with comments).
28 # 3. Deprecation is announced to discuss-webrtc@googlegroups.com and
29 # webrtc-users@google.com (internal list).
30 # 4. (later) The deprecated APIs are removed.
31 # Directories marked as DEPRECATED should not be used. They're only present in
32 # the list to support legacy downstream code.
24 NATIVE_API_DIRS = ( 33 NATIVE_API_DIRS = (
25 'talk/app/webrtc', 34 'talk/app/webrtc',
26 'webrtc', 35 'webrtc',
27 'webrtc/common_audio/include', # DEPRECATED (will go away). 36 'webrtc/base', # DEPRECATED.
37 'webrtc/common_audio/include', # DEPRECATED.
28 'webrtc/modules/audio_coding/include', 38 'webrtc/modules/audio_coding/include',
29 'webrtc/modules/audio_conference_mixer/include', # DEPRECATED (will go away). 39 'webrtc/modules/audio_conference_mixer/include', # DEPRECATED.
30 'webrtc/modules/audio_device/include', 40 'webrtc/modules/audio_device/include',
31 'webrtc/modules/audio_processing/include', 41 'webrtc/modules/audio_processing/include',
32 'webrtc/modules/bitrate_controller/include', 42 'webrtc/modules/bitrate_controller/include',
33 'webrtc/modules/include', 43 'webrtc/modules/include',
34 'webrtc/modules/remote_bitrate_estimator/include', 44 'webrtc/modules/remote_bitrate_estimator/include',
35 'webrtc/modules/rtp_rtcp/include', 45 'webrtc/modules/rtp_rtcp/include',
36 'webrtc/modules/rtp_rtcp/source', # DEPRECATED (will go away). 46 'webrtc/modules/rtp_rtcp/source', # DEPRECATED.
37 'webrtc/modules/utility/include', 47 'webrtc/modules/utility/include',
38 'webrtc/modules/video_coding/codecs/h264/include', 48 'webrtc/modules/video_coding/codecs/h264/include',
39 'webrtc/modules/video_coding/codecs/i420/include', 49 'webrtc/modules/video_coding/codecs/i420/include',
40 'webrtc/modules/video_coding/codecs/vp8/include', 50 'webrtc/modules/video_coding/codecs/vp8/include',
41 'webrtc/modules/video_coding/codecs/vp9/include', 51 'webrtc/modules/video_coding/codecs/vp9/include',
42 'webrtc/modules/video_coding/include', 52 'webrtc/modules/video_coding/include',
43 'webrtc/system_wrappers/include', # DEPRECATED (will go away). 53 'webrtc/system_wrappers/include', # DEPRECATED.
44 'webrtc/voice_engine/include', 54 'webrtc/voice_engine/include',
45 ) 55 )
46 56
47 57
48 def _VerifyNativeApiHeadersListIsValid(input_api, output_api): 58 def _VerifyNativeApiHeadersListIsValid(input_api, output_api):
49 """Ensures the list of native API header directories is up to date.""" 59 """Ensures the list of native API header directories is up to date."""
50 non_existing_paths = [] 60 non_existing_paths = []
51 native_api_full_paths = [ 61 native_api_full_paths = [
52 input_api.os_path.join(input_api.PresubmitLocalPath(), 62 input_api.os_path.join(input_api.PresubmitLocalPath(),
53 *path.split('/')) for path in NATIVE_API_DIRS] 63 *path.split('/')) for path in NATIVE_API_DIRS]
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 for builder in masters[master]: 457 for builder in masters[master]:
448 if 'presubmit' in builder: 458 if 'presubmit' in builder:
449 # Do not trigger presubmit builders, since they're likely to fail 459 # Do not trigger presubmit builders, since they're likely to fail
450 # (e.g. OWNERS checks before finished code review), and we're running 460 # (e.g. OWNERS checks before finished code review), and we're running
451 # local presubmit anyway. 461 # local presubmit anyway.
452 pass 462 pass
453 else: 463 else:
454 try_config[master][builder] = ['defaulttests'] 464 try_config[master][builder] = ['defaulttests']
455 465
456 return try_config 466 return try_config
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698