Add webrtc/base to deprecated APIs.

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import json
 import os
 import platform
 import re
 import subprocess
 import sys
 
 
 # Directories that will be scanned by cpplint by the presubmit script.
 CPPLINT_DIRS = [
   'webrtc/audio',
   'webrtc/call',
   'webrtc/video_engine',
 ]
 
 NATIVE_API_DIRS = (
   'talk/app/webrtc',
   'webrtc',
+  'webrtc/base',  # DEPRECATED (will go away).

[kwiberg-webrtc, 2015/12/03 13:44:27]

What does DEPRECATED mean? That webrtc/base is going away? That external users
shouldn't include stuff from there directly? Indirectly?

[phoglund, 2015/12/03 13:58:55]

I guess what we want to say here is "don't depend on this thing directly."

[kjellander_webrtc, 2015/12/03 14:03:53]

I guess it could be phrased differently, but I mean going away from this list of
"supported" APIs, since we don't want to support it (but haven't been able to
update downstream code yet).
If they use another API that includes files from webrtc/base indirectly, that's
not their problem (just ours).
Yes.

[kwiberg-webrtc, 2015/12/03 14:52:28]

OK, sounds good. Perhaps a comment on line 24 that explains that this is the
list of directories where we don't change headers willy-nilly, and that
DEPRECATED means that the entry in question is going away from the list?

[kjellander_webrtc, 2015/12/03 15:12:34]

You're right. I added a descriptive comment now and removed the confusing "will
go away" text.

   'webrtc/common_audio/include',  # DEPRECATED (will go away).
   'webrtc/modules/audio_coding/include',
   'webrtc/modules/audio_conference_mixer/include',  # DEPRECATED (will go away).
   'webrtc/modules/audio_device/include',
   'webrtc/modules/audio_processing/include',
   'webrtc/modules/bitrate_controller/include',
   'webrtc/modules/include',
   'webrtc/modules/remote_bitrate_estimator/include',
   'webrtc/modules/rtp_rtcp/include',
   'webrtc/modules/rtp_rtcp/source',  # DEPRECATED (will go away).
@@ skipping 410 matching lines @@
     for builder in masters[master]:
       if 'presubmit' in builder:
         # Do not trigger presubmit builders, since they're likely to fail
         # (e.g. OWNERS checks before finished code review), and we're running
         # local presubmit anyway.
         pass
       else:
         try_config[master][builder] = ['defaulttests']
 
   return try_config