Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: PRESUBMIT.py

Issue 1497733002: Add webrtc/base to deprecated APIs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index fe9d0104a908878dc7dbcab59bf0e7e7405a269d..10838daf7dab02efb97fea284cf3adb59ea3c0de 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -24,6 +24,7 @@ CPPLINT_DIRS = [
NATIVE_API_DIRS = (
'talk/app/webrtc',
'webrtc',
+ 'webrtc/base', # DEPRECATED (will go away).
kwiberg-webrtc 2015/12/03 13:44:27 What does DEPRECATED mean? That webrtc/base is goi
phoglund 2015/12/03 13:58:55 I guess what we want to say here is "don't depend
kjellander_webrtc 2015/12/03 14:03:53 I guess it could be phrased differently, but I mea
kwiberg-webrtc 2015/12/03 14:52:28 OK, sounds good. Perhaps a comment on line 24 that
kjellander_webrtc 2015/12/03 15:12:34 You're right. I added a descriptive comment now an
'webrtc/common_audio/include', # DEPRECATED (will go away).
'webrtc/modules/audio_coding/include',
'webrtc/modules/audio_conference_mixer/include', # DEPRECATED (will go away).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698